From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt
Date: Fri, 29 May 2009 13:18:56 -0700 (PDT) [thread overview]
Message-ID: <20090529201856.1F451FC2BD@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Friday, 29 May 2009 14:05:15 +0200 <20090529120515.GB19812@redhat.com>
> > 5/12 still needs a comment about its assumption that tracehook_init_task()
> > allocated the struct iff appropriate.
>
> Not sure I understand... Where should I put this comment?
ptrace_init_task, to explain this line:
- if (unlikely(ptrace)) {
+ if (unlikely(child->ptrace_ctx)) {
> OK, will redo and resend. Perhaps I should send this series to you
> privately? I don't like to flood lkml again, the changes are cosmetic.
:-) Whatever you like. They will surely be posted at least twice more
before they get merged either way. The idea that any actual useful patches
might pollute the purity of the lkml stream is amusing. (Post them twice,
it will nudge up the signal-to-noise ratio. ;-)
Thanks,
Roland
prev parent reply other threads:[~2009-05-29 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 11:35 [RFC PATCH 0/12 v2] ptrace: introduce task_struct->ptrace_cxt Oleg Nesterov
2009-05-28 21:34 ` Roland McGrath
2009-05-29 12:05 ` Oleg Nesterov
2009-05-29 20:18 ` Roland McGrath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090529201856.1F451FC2BD@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox