Re: [PATCH] 8250: Fix oops from setserial

Alan Cox
2009-05-30T08:25:34Z

>
> > static void set_io_from_upio(struct uart_port *p)
> > {
> > + struct uart_8250_port *up = (struct uart_8250_port *)p;
>
> container_of() is nicer, IMO. It's clearer, and doesn't require that
> the uart_port be the fist member.

See the rest of the driver - it was written that way years ago and this
is just following the existing design.