From: Borislav Petkov <petkovbb@googlemail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: broken ide-tape
Date: Sun, 31 May 2009 18:17:41 +0200 [thread overview]
Message-ID: <20090531161740.GA7975@liondog.tnic> (raw)
In-Reply-To: <4A229998.6070808@gmail.com>
On Sun, May 31, 2009 at 04:52:08PM +0200, Jiri Slaby wrote:
> Hi,
>
> ide-tape is broken since commit 346331f82823682fb5c2df6e827db25d95cc2e92
> (ide-tape: remove atomic test/set macros for packet commands)
> from Apr 18 2008.
>
> The commit introduced flags which are defined as (1 << nr) and uses them
> in {clear,set,test}_bit. And hence it must oops on each do_request.
/me ducks behind the couch.
Ouch, that _is_ dumb, sorry. This is because we wanted to keep the
atomic ops for the pipeline handling (which got removed) and use
simple flags for the rest. And so the flags got mixed up and the mess
unleashed...
> Is it worth fixing (something like ilog2 added to each bit operation) or
> is a complete removal of the driver better "fix"?
Actually, the driver needs to be reaudited and fixed properly - we still
have some users left. I'm looking into it.
Thanks for catching that.
--
Regards/Gruss,
Boris.
prev parent reply other threads:[~2009-05-31 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 14:52 broken ide-tape Jiri Slaby
2009-05-31 16:17 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090531161740.GA7975@liondog.tnic \
--to=petkovbb@googlemail.com \
--cc=bzolnier@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox