Re: [PATCH 1/2] tracing/events: put TP_fast_assign into braces

[Frederic Weisbecker <fweisbec@gmail.com>]

On Mon, Jun 01, 2009 at 09:11:52AM -0400, Steven Rostedt wrote:
> 
> 
> 
> On Mon, 1 Jun 2009, Li Zefan wrote:
> 
> > Currently TP_fast_assin has a limitation that we can't define local
> > variables in it.
> > 
> > Here's one use case when we introduce __dynamic_array():
> > 
> > TP_fast_assign(
> > 	type *p = __get_dynamic_array(item);
> > 
> > 	foo(p);
> > 	bar(p);
> > ),
> > 
> > [ Impact: allow defining local variables in TP_fast_assign ]
> > 
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> Thanks Li,
> 
> I'll pull it in.
> 
> -- Steve

Hi Steve,

Note, they depend on the following patch:

tracing/events: fix a typo in __string() format output

You can pick it from:

git://git.kernel.org/pub/scm/linux/kernel/git/frederic/random-tracing.git
	tracing/core

Thanks!

 
> > ---
> >  include/trace/ftrace.h |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
> > index 9276ec4..ee92682 100644
> > --- a/include/trace/ftrace.h
> > +++ b/include/trace/ftrace.h
> > @@ -471,7 +471,7 @@ static void ftrace_raw_event_##call(proto)				\
> >  		return;							\
> >  	entry	= ring_buffer_event_data(event);			\
> >  									\
> > -	assign;								\
> > +	{ assign; }							\
> >  									\
> >  	if (!filter_current_check_discard(event_call, entry, event))	\
> >  		trace_nowake_buffer_unlock_commit(event, irq_flags, pc); \
> > -- 
> > 1.5.4.rc3
> > 
> > 
> >