From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pavel Machek <pavel@ucw.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Ondrej Zary <linux@rainbow-software.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix floppy hibernation
Date: Mon, 1 Jun 2009 22:52:02 +0200 [thread overview]
Message-ID: <200906012252.02862.rjw@sisk.pl> (raw)
In-Reply-To: <20090601195159.GC29610@elte.hu>
On Monday 01 June 2009, Ingo Molnar wrote:
>
> * Pavel Machek <pavel@ucw.cz> wrote:
>
> > On Sat 2009-05-30 18:04:25, Ondrej Zary wrote:
> > > Hello,
> > > floppy driver was always missing hibernation support. After resume, floppy did
> > > not work (until a couple of disk reinserts and retries), producing errors like
> > > this:
> > > end_request: I/O error, dev fd0, sector 0
> > >
> > > Ingo Molnar tried to fix it in 2006: http://lkml.org/lkml/2006/11/12/92
> > >
> > >
> > >
> > >
> > > Based on Ingo Molnar's patch from 2006, this makes the floppy work after
> > > resume from hibernation, at least on my machine.
> > >
> > >
> > > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> > Acked-by: Pavel Machek <pavel@ucw.cz>
>
> nice patch ... thanks for picking up what i left unfinished.
I guess I'll take it to the suspend tree. Or is it a better place?
Best,
Rafael
next prev parent reply other threads:[~2009-06-01 20:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-30 16:04 [PATCH] Fix floppy hibernation Ondrej Zary
2009-06-01 11:43 ` Pavel Machek
2009-06-01 19:51 ` Ingo Molnar
2009-06-01 20:52 ` Rafael J. Wysocki [this message]
2009-06-01 23:12 ` Ingo Molnar
2009-06-01 23:45 ` Andrew Morton
2009-06-02 16:30 ` Ondrej Zary
2009-06-02 22:15 ` Andrew Morton
2009-06-03 6:13 ` Ondrej Zary
2009-06-03 6:25 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906012252.02862.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox