[PATCH] update kernel's scripts/bloat-o-meter from busybox

[PATCH] update kernel's scripts/bloat-o-meter from busybox

[Robin Getz]

From: "Rob Landley" <rob@landley.net>
From: "Denis Vlasenko" <vda.linux@googlemail.com>
From: "Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>

Since bloat-o-meter was added to the kernel's source tree, it has received 
little attention - either it works really well - or no one uses it. I suspect 
the first :)

However - some folks who have been using it more (mainly as part of busybox) 
have been poking at it more often - and the output is a little more friendly 
now.

http://git.busybox.net/busybox/log/scripts/bloat-o-meter

I think Rob had been sending early patches both places, but somewhere along 
the line things never made it to lkml.

Acked-by: Robin Getz <rgetz@blackfin.uclinux.org>

---
Since none of this is from me, I can only add my Acked by. Bernhard, Denis, 
and Rob will need to add their Signed-off-by separately.

----


 bloat-o-meter |   37 +++++++++++++++++++++++++++++--------
 1 file changed, 29 insertions(+), 8 deletions(-)



Index: scripts/bloat-o-meter
===================================================================
--- scripts/bloat-o-meter	(revision 6437)
+++ scripts/bloat-o-meter	(working copy)
@@ -9,18 +9,37 @@
 
 import sys, os, re
 
-if len(sys.argv) != 3:
+def usage():
     sys.stderr.write("usage: %s file1 file2\n" % sys.argv[0])
     sys.exit(-1)
 
+if len(sys.argv) < 3:
+    usage()
+
+for f in sys.argv[1], sys.argv[2]:
+    if not os.path.exists(f):
+        sys.stderr.write("Error: file '%s' does not exist\n" % f)
+        usage()
+
+nm_args = " ".join([x for x in sys.argv[3:]])
 def getsizes(file):
     sym = {}
-    for l in os.popen("nm --size-sort " + file).readlines():
-        size, type, name = l[:-1].split()
-        if type in "tTdDbB":
+    for l in os.popen("nm --size-sort %s %s" % (nm_args, file)).readlines():
+    	l = l.strip()
+	# Skip empty lines
+        if not len(l): continue
+	# Skip archive members
+        if len(l.split()) == 1 and l.endswith(':'):
+          continue
+        size, type, name = l.split()
+        if type in "tTdDbBrR":
             # function names begin with '.' on 64-bit powerpc
             if "." in name[1:]: name = "static." + name.split(".")[0]
             sym[name] = sym.get(name, 0) + int(size, 16)
+    for l in os.popen("readelf -S " + file).readlines():
+        x = l.split()
+        if len(x)<6 or x[1] != ".rodata": continue
+        sym[".rodata"] = int(x[5], 16)
     return sym
 
 old = getsizes(sys.argv[1])
@@ -53,8 +72,10 @@
 delta.sort()
 delta.reverse()
 
-print "add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
-      (add, remove, grow, shrink, up, -down, up-down)
-print "%-40s %7s %7s %+7s" % ("function", "old", "new", "delta")
+print "%-48s %7s %7s %+7s" % ("function", "old", "new", "delta")
 for d, n in delta:
-    if d: print "%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
+    if d: print "%-48s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
+print "-"*78
+total="(add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s)%%sTotal: %s 
bytes"\
+    % (add, remove, grow, shrink, up, -down, up-down)
+print total % (" "*(80-len(total)))

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Matt Mackall]

On Mon, 2009-06-01 at 15:26 -0400, Robin Getz wrote:
> From: "Rob Landley" <rob@landley.net>
> From: "Denis Vlasenko" <vda.linux@googlemail.com>
> From: "Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>
> 
> Since bloat-o-meter was added to the kernel's source tree, it has received 
> little attention - either it works really well - or no one uses it. I suspect 
> the first :)
> 
> However - some folks who have been using it more (mainly as part of busybox) 
> have been poking at it more often - and the output is a little more friendly 
> now.
> 
> http://git.busybox.net/busybox/log/scripts/bloat-o-meter
> 
> I think Rob had been sending early patches both places, but somewhere along 
> the line things never made it to lkml.

I probably dropped them on the ground during a busy spell.

> Acked-by: Robin Getz <rgetz@blackfin.uclinux.org>
> 
> ---
> Since none of this is from me, I can only add my Acked by. Bernhard, Denis, 
> and Rob will need to add their Signed-off-by separately.
> 
> ----
> 
> 
>  bloat-o-meter |   37 +++++++++++++++++++++++++++++--------
>  1 file changed, 29 insertions(+), 8 deletions(-)
> 
> 
> 
> Index: scripts/bloat-o-meter
> ===================================================================
> --- scripts/bloat-o-meter	(revision 6437)
> +++ scripts/bloat-o-meter	(working copy)
> @@ -9,18 +9,37 @@
>  
>  import sys, os, re
>  
> -if len(sys.argv) != 3:
> +def usage():
>      sys.stderr.write("usage: %s file1 file2\n" % sys.argv[0])
>      sys.exit(-1)
>  
> +if len(sys.argv) < 3:
> +    usage()
> +
> +for f in sys.argv[1], sys.argv[2]:

in sys.argv[1:3]:  is a bit more standard

But this test should instead happen inside getsizes, no loop needed.

> +    if not os.path.exists(f):
> +        sys.stderr.write("Error: file '%s' does not exist\n" % f)
> +        usage()
> +
> +nm_args = " ".join([x for x in sys.argv[3:]])

nm_args = " ".join(sys.argv[3:])

>  def getsizes(file):
>      sym = {}
> -    for l in os.popen("nm --size-sort " + file).readlines():
> -        size, type, name = l[:-1].split()
> -        if type in "tTdDbB":
> +    for l in os.popen("nm --size-sort %s %s" % (nm_args, file)).readlines():
> +    	l = l.strip()
> +	# Skip empty lines
> +        if not len(l): continue

(seems to be some whitespace damage? there should be no tabs in this
source)

if not l

> +	# Skip archive members
> +        if len(l.split()) == 1 and l.endswith(':'):

if ' ' not in l ...

> +          continue
> +        size, type, name = l.split()
> +        if type in "tTdDbBrR":
>              # function names begin with '.' on 64-bit powerpc
>              if "." in name[1:]: name = "static." + name.split(".")[0]
>              sym[name] = sym.get(name, 0) + int(size, 16)
> +    for l in os.popen("readelf -S " + file).readlines():
> +        x = l.split()
> +        if len(x)<6 or x[1] != ".rodata": continue
> +        sym[".rodata"] = int(x[5], 16)

Not sure what this addition is about?

>      return sym
>  
>  old = getsizes(sys.argv[1])
> @@ -53,8 +72,10 @@
>  delta.sort()
>  delta.reverse()
>  
> -print "add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
> -      (add, remove, grow, shrink, up, -down, up-down)
> -print "%-40s %7s %7s %+7s" % ("function", "old", "new", "delta")
> +print "%-48s %7s %7s %+7s" % ("function", "old", "new", "delta")
>  for d, n in delta:
> -    if d: print "%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
> +    if d: print "%-48s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
> +print "-"*78
> +total="(add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s)%%sTotal: %s 
> bytes"\
> +    % (add, remove, grow, shrink, up, -down, up-down)
> +print total % (" "*(80-len(total)))

Not terribly excited about this last bit, which is going out of its way
to right-align the total? Who cares about that?

-- 
http://selenic.com : development and support for Mercurial and Linux

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Mike Frysinger]

On Mon, Jun 1, 2009 at 15:48, Matt Mackall wrote:
> On Mon, 2009-06-01 at 15:26 -0400, Robin Getz wrote:
>> --- scripts/bloat-o-meter     (revision 6437)
>> +++ scripts/bloat-o-meter     (working copy)
>> @@ -9,18 +9,37 @@
>>
>>  import sys, os, re
>>
>> -if len(sys.argv) != 3:
>> +def usage():
>>      sys.stderr.write("usage: %s file1 file2\n" % sys.argv[0])
>>      sys.exit(-1)
>>
>> +if len(sys.argv) < 3:
>> +    usage()
>> +
>> +for f in sys.argv[1], sys.argv[2]:
>
> in sys.argv[1:3]:  is a bit more standard
>
> But this test should instead happen inside getsizes, no loop needed.
>
>> +    if not os.path.exists(f):
>> +        sys.stderr.write("Error: file '%s' does not exist\n" % f)
>> +        usage()
>> +
>> +nm_args = " ".join([x for x in sys.argv[3:]])
>
> nm_args = " ".join(sys.argv[3:])

ive made the argv changes in busybox upstream

>>  def getsizes(file):
>>      sym = {}
>> -    for l in os.popen("nm --size-sort " + file).readlines():
>> -        size, type, name = l[:-1].split()
>> -        if type in "tTdDbB":
>> +    for l in os.popen("nm --size-sort %s %s" % (nm_args, file)).readlines():
>> +     l = l.strip()
>> +     # Skip empty lines
>> +        if not len(l): continue
>
> (seems to be some whitespace damage? there should be no tabs in this
> source)

fixed the whitespace damage (all spaces)

>>  old = getsizes(sys.argv[1])
>> @@ -53,8 +72,10 @@
>>  delta.sort()
>>  delta.reverse()
>>
>> -print "add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
>> -      (add, remove, grow, shrink, up, -down, up-down)
>> -print "%-40s %7s %7s %+7s" % ("function", "old", "new", "delta")
>> +print "%-48s %7s %7s %+7s" % ("function", "old", "new", "delta")
>>  for d, n in delta:
>> -    if d: print "%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
>> +    if d: print "%-48s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
>> +print "-"*78
>> +total="(add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s)%%sTotal: %s
>> bytes"\
>> +    % (add, remove, grow, shrink, up, -down, up-down)
>> +print total % (" "*(80-len(total)))
>
> Not terribly excited about this last bit, which is going out of its way
> to right-align the total? Who cares about that?

it makes things a lot easier to read, especially in commit scripts

as for the rest of your comments, Denis or Rob can tackle those
-mike

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Robin Getz]

On Mon 1 Jun 2009 15:48, Matt Mackall pondered:
> On Mon, 2009-06-01 at 15:26 -0400, Robin Getz wrote:
> > From: "Rob Landley" <rob@landley.net>
> > From: "Denis Vlasenko" <vda.linux@googlemail.com>
> > From: "Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>
> > 
> > Since bloat-o-meter was added to the kernel's source tree, it has
> > received little attention - either it works really well - or no
> > one uses it. I suspect the first :)
> > 
> > However - some folks who have been using it more (mainly as part 
> > of busybox) have been poking at it more often - and the output is
> > a little more friendly  now.
> > 
> > http://git.busybox.net/busybox/log/scripts/bloat-o-meter
> > 
> > I think Rob had been sending early patches both places, but
> > somewhere along the line things never made it to lkml.
> 
> I probably dropped them on the ground during a busy spell.

Sorry - I didn't mean to sound like I was trying to blame anyone. 


> > Acked-by: Robin Getz <rgetz@blackfin.uclinux.org>
> > 
> > ---
> > Since none of this is from me, I can only add my Acked by. Bernhard,
> > Denis, and Rob will need to add their Signed-off-by separately.
> > 
> > ----
> > 
> > 
> >  bloat-o-meter |   37 +++++++++++++++++++++++++++++--------
> >  1 file changed, 29 insertions(+), 8 deletions(-)
> > 
> > 
> > 
> > Index: scripts/bloat-o-meter
> > ===================================================================
> > --- scripts/bloat-o-meter	(revision 6437)
> > +++ scripts/bloat-o-meter	(working copy)
> > @@ -9,18 +9,37 @@
> >  
> >  import sys, os, re
> >  
> > -if len(sys.argv) != 3:
> > +def usage():
> >      sys.stderr.write("usage: %s file1 file2\n" % sys.argv[0])
> >      sys.exit(-1)
> >  
> > +if len(sys.argv) < 3:
> > +    usage()
> > +
> > +for f in sys.argv[1], sys.argv[2]:
> 
> in sys.argv[1:3]:  is a bit more standard
> 
> But this test should instead happen inside getsizes, no loop needed.
> 
> > +    if not os.path.exists(f):
> > +        sys.stderr.write("Error: file '%s' does not exist\n" % f)
> > +        usage()
> > +
> > +nm_args = " ".join([x for x in sys.argv[3:]])
> 
> nm_args = " ".join(sys.argv[3:])
> 
> >  def getsizes(file):
> >      sym = {}
> > -    for l in os.popen("nm --size-sort " + file).readlines():
> > -        size, type, name = l[:-1].split()
> > -        if type in "tTdDbB":
> > +    for l in os.popen("nm --size-sort %s %s" % (nm_args, file)).readlines():
> > +    	l = l.strip()
> > +	# Skip empty lines
> > +        if not len(l): continue
> 
> (seems to be some whitespace damage? there should be no tabs in this
> source)

That is the way it is in the busybox git tree (until Mike fixed it 10 minutes ago)
 - I'll fix it on the next version I send...

> if not l

same.

> > +	# Skip archive members
> > +        if len(l.split()) == 1 and l.endswith(':'):
> 
> if ' ' not in l ...

http://git.busybox.net/busybox/commit/?id=49bdf28c320bf4e02048eb0cbd115d84b8467cd9

OK with me - if it is OK with Bernhard.



> > +          continue
> > +        size, type, name = l.split()
> > +        if type in "tTdDbBrR":
> >              # function names begin with '.' on 64-bit powerpc
> >              if "." in name[1:]: name = "static." + name.split(".")[0]
> >              sym[name] = sym.get(name, 0) + int(size, 16)
> > +    for l in os.popen("readelf -S " + file).readlines():
> > +        x = l.split()
> > +        if len(x)<6 or x[1] != ".rodata": continue
> > +        sym[".rodata"] = int(x[5], 16)
> 
> Not sure what this addition is about?

I think this is from Rob.

http://git.busybox.net/busybox/commit/?id=f14f7fc5cad5cac1a0913b85c8304f6fb77697ad



> >      return sym
> >  
> >  old = getsizes(sys.argv[1])
> > @@ -53,8 +72,10 @@
> >  delta.sort()
> >  delta.reverse()
> >  
> > -print "add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s (%s)" % \
> > -      (add, remove, grow, shrink, up, -down, up-down)
> > -print "%-40s %7s %7s %+7s" % ("function", "old", "new", "delta")
> > +print "%-48s %7s %7s %+7s" % ("function", "old", "new", "delta")
> >  for d, n in delta:
> > -    if d: print "%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
> > +    if d: print "%-48s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d)
> > +print "-"*78
> > +total="(add/remove: %s/%s grow/shrink: %s/%s up/down: %s/%s)%%sTotal: %s 
> > bytes"\
> > +    % (add, remove, grow, shrink, up, -down, up-down)
> > +print total % (" "*(80-len(total)))
> 
> Not terribly excited about this last bit, which is going out of its way
> to right-align the total? Who cares about that?

Rob did. :) Same patch as above.

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Matt Mackall]

On Mon, 2009-06-01 at 16:57 -0400, Robin Getz wrote:
> On Mon 1 Jun 2009 15:48, Matt Mackall pondered:
> > On Mon, 2009-06-01 at 15:26 -0400, Robin Getz wrote:
> > > From: "Rob Landley" <rob@landley.net>
> > > From: "Denis Vlasenko" <vda.linux@googlemail.com>
> > > From: "Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>
> > > 
> > > Since bloat-o-meter was added to the kernel's source tree, it has
> > > received little attention - either it works really well - or no
> > > one uses it. I suspect the first :)
> > > 
> > > However - some folks who have been using it more (mainly as part 
> > > of busybox) have been poking at it more often - and the output is
> > > a little more friendly  now.
> > > 
> > > http://git.busybox.net/busybox/log/scripts/bloat-o-meter
> > > 
> > > I think Rob had been sending early patches both places, but
> > > somewhere along the line things never made it to lkml.
> > 
> > I probably dropped them on the ground during a busy spell.
> 
> Sorry - I didn't mean to sound like I was trying to blame anyone. 

And I'm just making sure Rob doesn't feel blamed. He did send me
patches, and they didn't go anywhere.

I can do a round of make-it-idiomatic-python after we get this merged,
that'll probably be more efficient than me picking nits.

-- 
http://selenic.com : development and support for Mercurial and Linux

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Rob Landley]

On Monday 01 June 2009 16:17:20 Matt Mackall wrote:
> > > > I think Rob had been sending early patches both places, but
> > > > somewhere along the line things never made it to lkml.
> > >
> > > I probably dropped them on the ground during a busy spell.
> >
> > Sorry - I didn't mean to sound like I was trying to blame anyone.
>
> And I'm just making sure Rob doesn't feel blamed. He did send me
> patches, and they didn't go anywhere.

Oh go ahead and blame me, I'm used to it. :)

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Bernhard Reutner-Fischer]

On Mon, Jun 01, 2009 at 04:57:20PM -0400, Robin Getz wrote:
>On Mon 1 Jun 2009 15:48, Matt Mackall pondered:
>> On Mon, 2009-06-01 at 15:26 -0400, Robin Getz wrote:

>> > +	# Skip archive members
>> > +        if len(l.split()) == 1 and l.endswith(':'):
>> 
>> if ' ' not in l ...
>
>http://git.busybox.net/busybox/commit/?id=49bdf28c320bf4e02048eb0cbd115d84b8467cd9
>
>OK with me - if it is OK with Bernhard.

Fine with me either way, sure. All parts i ever touched in bloat-o-meter
(and kbuild, kconfig) are:
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>

thanks,

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Robin Getz]

On Tue 2 Jun 2009 09:07, Bernhard Reutner-Fischer pondered:
> Fine with me either way, sure. All parts i ever touched in bloat-o-meter
> (and kbuild, kconfig) are:
> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>

On Tue 2 Jun 2009 01:59, Rob Landley pondered:
> 
> Nah, the patches I sent got applied, I just haven't messed with it in
> the past couple years.  So you don't need my signed-off-by, but I'm happy
> to give you an:
> 
> Acked-by: Rob Landley <rob@landley.net>

So - that is Bernhard & Rob -- 

Denis you there?


Sam/Matt - assuming that Denis sends his - do you want the 5 or so small 
patchsets, or just one, like I sent yesterday (which is also pretty small).

-Robin

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Sam Ravnborg]

On Tue, Jun 02, 2009 at 04:11:35PM -0400, Robin Getz wrote:
> On Tue 2 Jun 2009 09:07, Bernhard Reutner-Fischer pondered:
> > Fine with me either way, sure. All parts i ever touched in bloat-o-meter
> > (and kbuild, kconfig) are:
> > Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> 
> On Tue 2 Jun 2009 01:59, Rob Landley pondered:
> > 
> > Nah, the patches I sent got applied, I just haven't messed with it in
> > the past couple years.  So you don't need my signed-off-by, but I'm happy
> > to give you an:
> > 
> > Acked-by: Rob Landley <rob@landley.net>
> 
> So - that is Bernhard & Rob -- 
> 
> Denis you there?
> 
> 
> Sam/Matt - assuming that Denis sends his - do you want the 5 or so small 
> patchsets, or just one, like I sent yesterday (which is also pretty small).

One patch would be fine.

Thanks,
	Sam

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Denys Vlasenko]

On Tue, Jun 2, 2009 at 10:11 PM, Robin Getz<rgetz@blackfin.uclinux.org> wrote:
> On Tue 2 Jun 2009 09:07, Bernhard Reutner-Fischer pondered:
>> Fine with me either way, sure. All parts i ever touched in bloat-o-meter
>> (and kbuild, kconfig) are:
>> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
>
> On Tue 2 Jun 2009 01:59, Rob Landley pondered:
>>
>> Nah, the patches I sent got applied, I just haven't messed with it in
>> the past couple years.  So you don't need my signed-off-by, but I'm happy
>> to give you an:
>>
>> Acked-by: Rob Landley <rob@landley.net>
>
> So - that is Bernhard & Rob --
>
> Denis you there?

No internet at home at the moment. Sorry for the delay.

> Sam/Matt - assuming that Denis sends his

Sure,

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

--
vda

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Sam Ravnborg]

On Wed, Jun 10, 2009 at 02:27:14PM +0200, Denys Vlasenko wrote:
> On Tue, Jun 2, 2009 at 10:11 PM, Robin Getz<rgetz@blackfin.uclinux.org> wrote:
> > On Tue 2 Jun 2009 09:07, Bernhard Reutner-Fischer pondered:
> >> Fine with me either way, sure. All parts i ever touched in bloat-o-meter
> >> (and kbuild, kconfig) are:
> >> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
> >
> > On Tue 2 Jun 2009 01:59, Rob Landley pondered:
> >>
> >> Nah, the patches I sent got applied, I just haven't messed with it in
> >> the past couple years.  So you don't need my signed-off-by, but I'm happy
> >> to give you an:
> >>
> >> Acked-by: Rob Landley <rob@landley.net>
> >
> > So - that is Bernhard & Rob --
> >
> > Denis you there?
> 
> No internet at home at the moment. Sorry for the delay.
> 
> > Sam/Matt - assuming that Denis sends his
> 
> Sure,
> 
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

I have not seen any patch yet (or I have deleted it by mistake).

	Sam

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Rob Landley]

On Monday 01 June 2009 14:48:52 Matt Mackall wrote:
> On Mon, 2009-06-01 at 15:26 -0400, Robin Getz wrote:
> > From: "Rob Landley" <rob@landley.net>
> > From: "Denis Vlasenko" <vda.linux@googlemail.com>
> > From: "Bernhard Reutner-Fischer" <rep.dot.nop@gmail.com>
> >
> > Since bloat-o-meter was added to the kernel's source tree, it has
> > received little attention - either it works really well - or no one uses
> > it. I suspect the first :)
> >
> > However - some folks who have been using it more (mainly as part of
> > busybox) have been poking at it more often - and the output is a little
> > more friendly now.
> >
> > http://git.busybox.net/busybox/log/scripts/bloat-o-meter
> >
> > I think Rob had been sending early patches both places, but somewhere
> > along the line things never made it to lkml.
>
> I probably dropped them on the ground during a busy spell.

Nah, the patches I sent got applied, I just haven't messed with it in the past 
couple years.  So you don't need my signed-off-by, but I'm happy to give you 
an:

Acked-by: Rob Landley <rob@landley.net>

This was actually a series of five patches in the busybox repository, with 
descriptions.  Unfortunately, they recently converted the repository to git.  
Here are the big not remotely human readable git commit tags:

2425bdce34cd142b29eabad00927a9c473b05ecb
45aebfd32d30de492c6c714cd5b6a08ae4a53867
49bdf28c320bf4e02048eb0cbd115d84b8467cd9
7bd8d8fd264a72f9c228da3ca238eae1b2ad8ce1
cf575ca8561c53ef8299e9efcebb9dce96de2ff0

And the repository's at git://busybox.net/busybox.git


Rob

P.S.  I'd attach the 5 patch+descriptions, but I just spent fifteen minutes 
fighting with git to try to convince "git log -p" that when I list a specific 
commit on the command line I want it to spit out the description and patch for 
JUST THAT ONE COMMIT and not log the history back to Grace Hopper's graduation 
ceremony, and I ran out of interest before git ran out of ways to have a 
horrible user interface and man pages written by Tolstoy.  The man page for 
git-log is 1047 lines long, describing in horrific detail things I don't want 
it to do.  I gave up reading it about the point it started describing "parent 
rewriting", and went to google instead.  Google for "git log single patch" 
implies I should have a command named git-format-patch, which Xubuntu didn't 
install when I asked for git-core, and which I'm not hunting down right now...
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Joe Perches]

On Tue, 2009-06-02 at 00:59 -0500, Rob Landley wrote:
> P.S.  I'd attach the 5 patch+descriptions, but I just spent fifteen minutes 
> fighting with git to try to convince "git log -p" that when I list a specific 
> commit on the command line I want it to spit out the description and patch for 
> JUST THAT ONE COMMIT and not log the history back to Grace Hopper's graduation 
> ceremony

git log -p -1 commit

git has a highly intelligent and consistent command-line interface...
damn, I forgot what the sarcasm argument is

Re: [PATCH] update kernel's scripts/bloat-o-meter from busybox

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

On Mon, 2009-06-01 at 23:10 -0700, Joe Perches wrote:
> On Tue, 2009-06-02 at 00:59 -0500, Rob Landley wrote:
> > P.S.  I'd attach the 5 patch+descriptions, but I just spent fifteen minutes 
> > fighting with git to try to convince "git log -p" that when I list a specific 
> > commit on the command line I want it to spit out the description and patch for 
> > JUST THAT ONE COMMIT and not log the history back to Grace Hopper's graduation 
> > ceremony
> 
> git log -p -1 commit

Or more simply:

git show <commit>

cheers

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]