public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 08/10] tracing: remove redundant SOFTIRQ from softirq event traces
Date: Tue, 02 Jun 2009 00:43:23 -0400	[thread overview]
Message-ID: <20090602044340.946664871@goodmis.org> (raw)
In-Reply-To: 20090602044315.439593107@goodmis.org

[-- Attachment #1: 0008-tracing-remove-redundant-SOFTIRQ-from-softirq-event-.patch --]
[-- Type: text/plain, Size: 1666 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

After converting the softirq tracer to use te flags options, this
caused a regression with the name. Since the flag was used directly
it was printed out (i.e. HRTIMER_SOFTIRQ).

This patch only shows the softirq name without the SOFTIRQ part.

[ Impact: fix regression of output from softirq events ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 include/trace/events/irq.h |   24 ++++++++++++------------
 1 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/include/trace/events/irq.h b/include/trace/events/irq.h
index 683fb36..b0c7ede 100644
--- a/include/trace/events/irq.h
+++ b/include/trace/events/irq.h
@@ -7,18 +7,18 @@
 #undef TRACE_SYSTEM
 #define TRACE_SYSTEM irq
 
-#define softirq_name(sirq) { sirq, #sirq }
-#define show_softirq_name(val)						\
-	__print_symbolic(val,						\
-			 softirq_name(HI_SOFTIRQ),			\
-			 softirq_name(TIMER_SOFTIRQ),			\
-			 softirq_name(NET_TX_SOFTIRQ),			\
-			 softirq_name(NET_RX_SOFTIRQ),			\
-			 softirq_name(BLOCK_SOFTIRQ),			\
-			 softirq_name(TASKLET_SOFTIRQ),			\
-			 softirq_name(SCHED_SOFTIRQ),			\
-			 softirq_name(HRTIMER_SOFTIRQ),			\
-			 softirq_name(RCU_SOFTIRQ))
+#define softirq_name(sirq) { sirq##_SOFTIRQ, #sirq }
+#define show_softirq_name(val)			\
+	__print_symbolic(val,			\
+			 softirq_name(HI),	\
+			 softirq_name(TIMER),	\
+			 softirq_name(NET_TX),	\
+			 softirq_name(NET_RX),	\
+			 softirq_name(BLOCK),	\
+			 softirq_name(TASKLET),	\
+			 softirq_name(SCHED),	\
+			 softirq_name(HRTIMER),	\
+			 softirq_name(RCU))
 
 /**
  * irq_handler_entry - called immediately before the irq action handler
-- 
1.6.3.1

-- 

  parent reply	other threads:[~2009-06-02  4:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02  4:43 [PATCH 00/10] [GIT PULL] tracing: various updates Steven Rostedt
2009-06-02  4:43 ` [PATCH 01/10] ftrace: add kernel command line function filtering Steven Rostedt
2009-06-02  4:43 ` [PATCH 02/10] tracing: fix config options to not show when automatically selected Steven Rostedt
2009-06-02  4:43 ` [PATCH 03/10] tracing: combine the default tracers into one config Steven Rostedt
2009-06-02  4:43 ` [PATCH 04/10] tracing/events: fix a typo in __string() format output Steven Rostedt
2009-06-02  4:43 ` [PATCH 05/10] tracing/events: put TP_fast_assign into braces Steven Rostedt
2009-06-02  4:43 ` [PATCH 06/10] tracing/events: introduce __dynamic_array() Steven Rostedt
2009-06-02  4:43 ` [PATCH 07/10] tracing: add exports to use __print_symbolic and __print_flags from a module Steven Rostedt
2009-06-02  4:43 ` Steven Rostedt [this message]
2009-06-02  4:43 ` [PATCH 09/10] tracing: make trace pipe recognize latency format flag Steven Rostedt
2009-06-02  4:43 ` [PATCH 10/10] ftrace: do not profile functions when disabled Steven Rostedt
2009-06-02  8:30 ` [PATCH 00/10] [GIT PULL] tracing: various updates Ingo Molnar
2009-06-02  9:28   ` Ingo Molnar
2009-06-02 12:51     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090602044340.946664871@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox