From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 09/10] tracing: make trace pipe recognize latency format flag
Date: Tue, 02 Jun 2009 00:43:24 -0400 [thread overview]
Message-ID: <20090602044341.159038003@goodmis.org> (raw)
In-Reply-To: 20090602044315.439593107@goodmis.org
[-- Attachment #1: 0009-tracing-make-trace-pipe-recognize-latency-format-fla.patch --]
[-- Type: text/plain, Size: 1750 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The trace_pipe did not recognize the latency format flag and would produce
different output than the trace file. The problem was partly due that
the trace flags in the iterator was not set as well as the trace_pipe
zeros out part of the iterator (including the flags) to be able to use
the same routines as the trace file. trace_flags of the iterator should
not cause any problems when not zeroed out by for trace_pipe.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/linux/ftrace_event.h | 2 +-
kernel/trace/trace.c | 3 +++
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
index bbf40f6..5c093ff 100644
--- a/include/linux/ftrace_event.h
+++ b/include/linux/ftrace_event.h
@@ -51,6 +51,7 @@ struct trace_iterator {
int cpu_file;
struct mutex mutex;
struct ring_buffer_iter *buffer_iter[NR_CPUS];
+ unsigned long iter_flags;
/* The below is zeroed out in pipe_read */
struct trace_seq seq;
@@ -58,7 +59,6 @@ struct trace_iterator {
int cpu;
u64 ts;
- unsigned long iter_flags;
loff_t pos;
long idx;
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index a3a8a87..cae34c6 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -2826,6 +2826,9 @@ static int tracing_open_pipe(struct inode *inode, struct file *filp)
/* trace pipe does not show start of buffer */
cpumask_setall(iter->started);
+ if (trace_flags & TRACE_ITER_LATENCY_FMT)
+ iter->iter_flags |= TRACE_FILE_LAT_FMT;
+
iter->cpu_file = cpu_file;
iter->tr = &global_trace;
mutex_init(&iter->mutex);
--
1.6.3.1
--
next prev parent reply other threads:[~2009-06-02 4:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 4:43 [PATCH 00/10] [GIT PULL] tracing: various updates Steven Rostedt
2009-06-02 4:43 ` [PATCH 01/10] ftrace: add kernel command line function filtering Steven Rostedt
2009-06-02 4:43 ` [PATCH 02/10] tracing: fix config options to not show when automatically selected Steven Rostedt
2009-06-02 4:43 ` [PATCH 03/10] tracing: combine the default tracers into one config Steven Rostedt
2009-06-02 4:43 ` [PATCH 04/10] tracing/events: fix a typo in __string() format output Steven Rostedt
2009-06-02 4:43 ` [PATCH 05/10] tracing/events: put TP_fast_assign into braces Steven Rostedt
2009-06-02 4:43 ` [PATCH 06/10] tracing/events: introduce __dynamic_array() Steven Rostedt
2009-06-02 4:43 ` [PATCH 07/10] tracing: add exports to use __print_symbolic and __print_flags from a module Steven Rostedt
2009-06-02 4:43 ` [PATCH 08/10] tracing: remove redundant SOFTIRQ from softirq event traces Steven Rostedt
2009-06-02 4:43 ` Steven Rostedt [this message]
2009-06-02 4:43 ` [PATCH 10/10] ftrace: do not profile functions when disabled Steven Rostedt
2009-06-02 8:30 ` [PATCH 00/10] [GIT PULL] tracing: various updates Ingo Molnar
2009-06-02 9:28 ` Ingo Molnar
2009-06-02 12:51 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602044341.159038003@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox