Re: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3

Nick Piggin
2009-06-02T14:21:53Z

On Tue, Jun 02, 2009 at 10:12:22PM +0800, Wu Fengguang wrote:
> On Tue, Jun 02, 2009 at 10:06:39PM +0800, Andi Kleen wrote:
> > > > Ok you're right. That one is not needed. I will remove it.
> > >
> > > No! Please read the comment. In fact __remove_from_page_cache() has a
> > >
> > > BUG_ON(page_mapped(page));
> > >
> > > Or, at least correct that BUG_ON() line together.
> >
> > Yes, but we already have them unmapped earlier and the poison check
>
> But you commented "try_to_unmap can fail temporarily due to races."
>
> That's self-contradictory.

If you use the bloody code I posted (and suggested from the start),
then you DON'T HAVE TO WORRY ABOUT THIS, because it is handled by
the subsystem that knows about it.

How anybody can say it will make your code overcomplicated or "is
not much improvement" is just totally beyond me.