Re: [PATCH] [1/16] HWPOISON: Add page flag for poisoned pages

Rik van Riel
2009-05-29T16:34:51Z

Andi Kleen wrote:
> On Fri, May 29, 2009 at 12:10:24PM -0400, Rik van Riel wrote:
>> Andi Kleen wrote:
>>> On Wed, May 27, 2009 at 10:15:10PM +0100, Alan Cox wrote:
>>>> On Wed, 27 May 2009 22:12:26 +0200 (CEST)
>>>> Andi Kleen <andi@firstfloor.org> wrote:
>>>>
>>>>> Hardware poisoned pages need special handling in the VM and shouldn't be
>>>>> touched again. This requires a new page flag. Define it here.
>>>> Why can't you use PG_reserved ? That already indicates the page may not
>>>> even be present (which is effectively your situation at that point).
>>> Right now a page must be present with PG_reserved, otherwise /dev/mem,
>>> /proc/kcore
>>> lots of other things will explode.
>> Could we use a combination of, say PG_reserved and
>> PG_writeback to keep /dev/mem and /proc/kcore from
>> exploding ?
>
> They should just check for poisoned pages.

#define PagePoisoned(page) (PageReserved(page) && PageWriteback(page))

--
All rights reversed.