Re: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3

Wu Fengguang
2009-06-02T14:12:47Z

On Tue, Jun 02, 2009 at 10:06:39PM +0800, Andi Kleen wrote:
> > > Ok you're right. That one is not needed. I will remove it.
> >
> > No! Please read the comment. In fact __remove_from_page_cache() has a
> >
> > BUG_ON(page_mapped(page));
> >
> > Or, at least correct that BUG_ON() line together.
>
> Yes, but we already have them unmapped earlier and the poison check

But you commented "try_to_unmap can fail temporarily due to races."

That's self-contradictory.

> in the page fault handler should prevent remapping.
>
> So it really should not happen and if it happened we would deserve
> the BUG.
>
> -Andi
>
> --
> ak@linux.intel.com -- Speaking for myself only.