Re: [PATCH] [9/16] HWPOISON: Use bitmask/action code for try_to_unmap behaviour

Nick Piggin
2009-05-28T08:28:32Z

On Thu, May 28, 2009 at 10:03:19AM +0200, Andi Kleen wrote:
> On Thu, May 28, 2009 at 09:27:03AM +0200, Nick Piggin wrote:
> > Not a bad idea, but I would prefer to have a set of flags which tell
> > try_to_unmap what to do, and then combine them with #defines for
> > callers. Like gfp flags.
>
> That's exactly what the patch does?

There are a set of "actions" which is what the callers are, then a
set of modifiers. Just make it all modifiers and the callers can
use things that are | together.

> It just has actions and flags because the actions can be contradictory.
>
> > And just use regular bitops rather than this TTU_ACTION macro.
>
> TTU_ACTION does mask against multiple bits. None of the regular
> bitops do that.

&, | ?