public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Karsten Keil <isdn@linux-pingi.de>
To: Andreas Mohr <andi@lisas.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mISDN GIT: hfcpci cleanup failure on IRQ weirdness
Date: Tue, 2 Jun 2009 16:53:35 +0200	[thread overview]
Message-ID: <200906021653.36152.isdn@linux-pingi.de> (raw)
In-Reply-To: <20090602140250.GA3607@rhlx01.hs-esslingen.de>

On Dienstag, 2. Juni 2009 16:02:50 you wrote:
> Hi,
>
> > I have the suspicion that maybe I shouldn't be loading hisax upon boot
> > (and then immediately removing it before launching mISDN stuff),
> > since hfcpci acts very weird - perhaps it cannot recover card state fully
> > after hisax fumbling.
>
> Indeed, manually killed all hisax modules on the system, rebooted, and -
> it worked, immediately!
> (test call SIP -> Asterisk -> LCR -> ISDN -> out -> ISDN)
>
> IOW, we've got an unfortunate driver init state handling issue which one
> should perhaps investigate to make the driver more robust against
> varying hardware state.
> (my IRQ patch was a first step I guess ;)
>

Yes from mISDN side, but I do not see what inside hisax prevent mISDN from
getting IRQs after hisax was unloaded. And it works here on my test setup, I 
can load mISDN without an error, after unloading hisax.
One other issue with the HiSax  HFC PCI code is the FIFO DMA memory
allocation, this code is wrong  and broken (patch is under test).

> misdn_log still acts weird, though...
>
What does be weird here ?

> Thanks for all your important ISDN work! (given the sizeable number of
> commits mISDN will rather soon get there I think)
>
> BTW, could isdnlog be adapted to support mISDN relatively easily?
> (since adding CAPI support would take longer I guess)

isdnlog (beside that the isdnlog code is ugly enough) should be not a big 
issue, mISDN supports logging in parallel to the normal work, look at the
tools/loghex.c  code how to create a logging socket.
It should make things easier as with HiSax, since it will get the data as 
binary and not as hexdump.

> My guys are going semi-ballistic with their isdnlog taken out and shot ;)
>
> Andreas Mohr
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


  reply	other threads:[~2009-06-02 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 13:06 [PATCH] mISDN GIT: hfcpci cleanup failure on IRQ weirdness Andreas Mohr
2009-06-02 14:02 ` Andreas Mohr
2009-06-02 14:53   ` Karsten Keil [this message]
2009-06-02 15:44     ` Andreas Mohr
2009-06-02 15:29 ` Karsten Keil
2009-06-02 15:46   ` Andreas Mohr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906021653.36152.isdn@linux-pingi.de \
    --to=isdn@linux-pingi.de \
    --cc=andi@lisas.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox