public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kernel@vger.kernel.org,
	Robin Getz <rgetz@blackfin.uclinux.org>,
	Bryan Wu <cooloney@kernel.org>
Subject: Re: [PATCH] debugfs: use specified mode to possibly mark files read/write only
Date: Tue, 2 Jun 2009 16:23:10 -0700	[thread overview]
Message-ID: <20090602232310.GA26919@suse.de> (raw)
In-Reply-To: <1243926047-29704-1-git-send-email-vapier@gentoo.org>

On Tue, Jun 02, 2009 at 03:00:47AM -0400, Mike Frysinger wrote:
> From: Robin Getz <rgetz@blackfin.uclinux.org>
> 
> In many SoC implementations there are hardware registers can be read or
> write only.  This extends the debugfs to enforce the file permissions for
> these types of registers by providing a set of fops which are read or
> write only.  This assumes that the kernel developer knows more about the
> hardware than the user (even root users) -- which is normally true.
> 
> Signed-off-by: Robin Getz <rgetz@blackfin.uclinux.org>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
> you mention debugfs header file changes, but i don't see what would need
> changing ?  the mode checking is all done internally ...

Looks good to me.


      reply	other threads:[~2009-06-02 23:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06  2:57 debugfs & vfs file permission issue? Robin Getz
2009-01-06  5:48 ` Greg KH
2009-01-06  5:54   ` Mike Frysinger
2009-01-06  6:19     ` Greg KH
2009-01-06  6:32       ` Mike Frysinger
2009-01-06 12:05         ` Robin Getz
2009-01-06 15:12           ` Robin Getz
2009-01-06 15:20             ` Mike Frysinger
2009-01-06 21:20               ` Robin Getz
2009-01-06 23:11             ` Greg KH
2009-01-07  3:30               ` Robin Getz
2009-01-25 21:34             ` Greg KH
2009-06-02  7:00               ` [PATCH] debugfs: use specified mode to possibly mark files read/write only Mike Frysinger
2009-06-02 23:23                 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090602232310.GA26919@suse.de \
    --to=gregkh@suse.de \
    --cc=cooloney@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rgetz@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox