From: Baruch Siach <baruch@tkos.co.il>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net,
linux-arm-kernel@lists.arm.linux.org.uk, linux@arm.linux.org.uk
Subject: Re: [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller
Date: Wed, 3 Jun 2009 06:20:22 +0300 [thread overview]
Message-ID: <20090603032021.GA8721@tarshish> (raw)
In-Reply-To: <20090602160902.046ccffa.akpm@linux-foundation.org>
Hi Andrew,
On Tue, Jun 02, 2009 at 04:09:02PM -0700, Andrew Morton wrote:
> On Tue, 2 Jun 2009 23:48:10 +0300
> Baruch Siach <baruch@tkos.co.il> wrote:
>
> > This is a driver for the ARM PrimeCell PL061 GPIO AMBA peripheral. The driver
> > is implemented using the gpiolib framework.
>
> x86_64 allmodconfig:
>
> drivers/gpio/pl061.c: In function 'pl061_probe':
> drivers/gpio/pl061.c:254: error: 'SZ_4K' undeclared (first use in this function)
> drivers/gpio/pl061.c:254: error: (Each undeclared identifier is reported only once
> drivers/gpio/pl061.c:254: error: for each function it appears in.)
> drivers/gpio/pl061.c:306: error: implicit declaration of function 'set_irq_flags'
> drivers/gpio/pl061.c:306: error: 'IRQF_VALID' undeclared (first use in this function)
>
> I'll put a depends-on-ARM in there...
I guess a depends-on-ARM_AMBA would be better.
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2009-06-03 3:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 20:48 [PATCH v3] gpio: driver for PrimeCell PL061 GPIO controller Baruch Siach
2009-06-02 23:09 ` Andrew Morton
2009-06-03 3:20 ` Baruch Siach [this message]
2009-06-04 9:28 ` Russell King - ARM Linux
2009-06-04 15:58 ` Baruch Siach
2009-06-15 23:38 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603032021.GA8721@tarshish \
--to=baruch@tkos.co.il \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox