From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
paul@mad-scientist.net, linux-kernel@vger.kernel.org,
stable@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] coredump: Retry writes where appropriate
Date: Wed, 3 Jun 2009 00:15:45 -0700 (PDT) [thread overview]
Message-ID: <20090603071545.DFDA0FC333@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of Tuesday, 2 June 2009 17:29:44 +0200 <20090602152927.GA13515@redhat.com>
> Hmm. Does ->core_dump() report the state of ->sighand->action? I can't
> find any usage. Perhaps we can just ignore all signals except SIGKILL ?
I don't think anything uses that information. But it might one day,
or it might matter in some other arcane way (/proc/pid/status during
the dump is the only way I can think of to notice, but who knows).
I think it's better just not to get into any kludges that clobber
anything that records actual user-visible state that we normally
read out to userland in any fashion (even if none is known to do so
at dumping time or later). It's much more natural just to use pure
internal kernel state such as signal->flags for anything like this.
Thanks,
Roland
next prev parent reply other threads:[~2009-06-03 7:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 5:33 [PATCH] coredump: Retry writes where appropriate Paul Smith
2009-05-31 10:18 ` Alan Cox
2009-05-31 14:03 ` Olivier Galibert
2009-05-31 16:31 ` Alan Cox
2009-05-31 16:49 ` Olivier Galibert
2009-05-31 17:46 ` Paul Smith
2009-05-31 16:56 ` Paul Smith
2009-06-01 16:12 ` Oleg Nesterov
2009-06-01 16:41 ` Alan Cox
2009-06-01 17:11 ` Oleg Nesterov
2009-06-01 17:46 ` Alan Cox
2009-06-01 18:23 ` Oleg Nesterov
2009-06-01 20:38 ` Roland McGrath
2009-06-01 22:32 ` Oleg Nesterov
2009-06-01 23:02 ` Roland McGrath
2009-06-02 0:08 ` Oleg Nesterov
2009-06-03 7:09 ` Roland McGrath
2009-06-04 3:15 ` Oleg Nesterov
2009-06-04 17:14 ` Roland McGrath
2009-06-23 17:31 ` Paul Smith
2009-06-23 19:37 ` Oleg Nesterov
2009-07-07 19:37 ` Oleg Nesterov
2009-06-02 8:21 ` Alan Cox
2009-06-02 15:29 ` Oleg Nesterov
2009-06-03 7:15 ` Roland McGrath [this message]
2009-06-03 14:05 ` Paul Smith
2009-06-01 17:36 ` Paul Smith
2009-06-01 17:49 ` Alan Cox
2009-06-01 18:39 ` Paul Smith
2009-06-01 19:02 ` Alan Cox
2009-06-01 19:09 ` Andi Kleen
2009-06-01 19:06 ` Alan Cox
2009-06-01 19:14 ` Andi Kleen
2009-06-01 19:51 ` Paul Smith
2009-06-01 20:20 ` Oleg Nesterov
2009-06-01 21:34 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603071545.DFDA0FC333@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paul@mad-scientist.net \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox