From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matt Helsley <matthltc@us.ibm.com>,
xemul@parallels.com, containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, dave@linux.vnet.ibm.com,
mingo@elte.hu, torvalds@linux-foundation.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 4/9] exec_path 4/9: switch oprofile to ->exec_path
Date: Thu, 4 Jun 2009 03:06:13 +0400 [thread overview]
Message-ID: <20090603230613.GE853@x200.localdomain> (raw)
In-Reply-To: <20090603230422.GB853@x200.localdomain>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
drivers/oprofile/buffer_sync.c | 30 ++++++++----------------------
1 files changed, 8 insertions(+), 22 deletions(-)
diff --git a/drivers/oprofile/buffer_sync.c b/drivers/oprofile/buffer_sync.c
index 8574622..64c6d7d 100644
--- a/drivers/oprofile/buffer_sync.c
+++ b/drivers/oprofile/buffer_sync.c
@@ -25,6 +25,7 @@
#include <linux/workqueue.h>
#include <linux/notifier.h>
#include <linux/dcookies.h>
+#include <linux/path.h>
#include <linux/profile.h>
#include <linux/module.h>
#include <linux/fs.h>
@@ -213,30 +214,15 @@ static inline unsigned long fast_get_dcookie(struct path *path)
return cookie;
}
-
-/* Look up the dcookie for the task's first VM_EXECUTABLE mapping,
- * which corresponds loosely to "application name". This is
- * not strictly necessary but allows oprofile to associate
- * shared-library samples with particular applications
- */
-static unsigned long get_exec_dcookie(struct mm_struct *mm)
+static unsigned long get_exec_dcookie(struct task_struct *tsk)
{
unsigned long cookie = NO_COOKIE;
- struct vm_area_struct *vma;
+ struct path exec_path;
- if (!mm)
- goto out;
-
- for (vma = mm->mmap; vma; vma = vma->vm_next) {
- if (!vma->vm_file)
- continue;
- if (!(vma->vm_flags & VM_EXECUTABLE))
- continue;
- cookie = fast_get_dcookie(&vma->vm_file->f_path);
- break;
- }
-
-out:
+ get_task_exec_path(tsk, &exec_path);
+ if (exec_path.mnt && exec_path.dentry)
+ cookie = fast_get_dcookie(&exec_path);
+ path_put(&exec_path);
return cookie;
}
@@ -543,7 +529,7 @@ void sync_buffer(int cpu)
release_mm(oldmm);
mm = take_tasks_mm(new);
if (mm != oldmm)
- cookie = get_exec_dcookie(mm);
+ cookie = get_exec_dcookie(new);
add_user_ctx_switch(new, cookie);
}
if (op_cpu_buffer_get_size(&entry))
next prev parent reply other threads:[~2009-06-03 23:13 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 11:36 [PATCH 14/38] Remove struct mm_struct::exe_file et al Matt Helsley
2009-05-26 23:24 ` Andrew Morton
2009-05-31 21:54 ` Alexey Dobriyan
2009-05-31 22:19 ` Andrew Morton
2009-05-31 23:15 ` Linus Torvalds
2009-05-31 23:50 ` Andrew Morton
2009-06-01 0:02 ` Linus Torvalds
2009-06-03 23:04 ` [PATCH 1/9] exec_path 1/9: introduce ->exec_path and switch /proc/*/exe Alexey Dobriyan
2009-06-03 23:05 ` [PATCH 2/9] exec_path 2/9: switch audit to ->exec_path Alexey Dobriyan
2009-06-03 23:05 ` [PATCH 3/9] exec_path 3/9: switch TOMOYO " Alexey Dobriyan
2009-06-03 23:06 ` Alexey Dobriyan [this message]
2009-06-03 23:06 ` [PATCH 5/9] exec_path 5/9: make struct spu_context::owner task_struct Alexey Dobriyan
2009-06-03 23:06 ` [PATCH 6/9] exec_path 6/9: add struct spu::tsk Alexey Dobriyan
2009-06-03 23:07 ` [PATCH 7/9] exec_path 7/9: switch cell SPU thing to ->exec_path Alexey Dobriyan
2009-06-03 23:07 ` [PATCH 8/9] exec_path 8/9: remove ->exe_file et al Alexey Dobriyan
2009-06-03 23:08 ` [PATCH 9/9] exec_path 9/9: remove VM_EXECUTABLE Alexey Dobriyan
2009-06-04 7:24 ` Matt Helsley
2009-06-03 23:36 ` [PATCH 1/9] exec_path 1/9: introduce ->exec_path and switch /proc/*/exe Linus Torvalds
2009-06-04 7:55 ` Matt Helsley
2009-06-04 8:10 ` Matt Helsley
2009-06-04 15:07 ` Linus Torvalds
2009-06-04 21:30 ` Matt Helsley
2009-06-04 22:42 ` Alexey Dobriyan
2009-06-05 3:49 ` Matt Helsley
2009-06-05 10:45 ` Christoph Hellwig
2009-06-05 15:10 ` Linus Torvalds
2009-06-05 15:41 ` Alexey Dobriyan
2009-06-05 15:49 ` Linus Torvalds
2009-06-05 16:09 ` Alexey Dobriyan
2009-06-05 16:48 ` Linus Torvalds
2009-06-05 17:46 ` Alexey Dobriyan
2009-06-06 7:22 ` Al Viro
2009-06-15 22:10 ` Alexey Dobriyan
2009-06-01 17:30 ` [PATCH 14/38] Remove struct mm_struct::exe_file et al Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603230613.GE853@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox