From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 2/6] tracing/branch-profiler: fix return value check on register_stat_tracer
Date: Thu, 04 Jun 2009 01:25:42 -0400 [thread overview]
Message-ID: <20090604052613.005013632@goodmis.org> (raw)
In-Reply-To: 20090604052540.528802957@goodmis.org
[-- Attachment #1: 0002-tracing-branch-profiler-fix-return-value-check-on-re.patch --]
[-- Type: text/plain, Size: 805 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
The branch profiler incorrectly takes a zero return on register_stat_tracer
as an error. But zero means success.
[ Impact: remove annoying false warning on boot up ]
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/trace_branch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c
index 7a7a9fd..19c618f 100644
--- a/kernel/trace/trace_branch.c
+++ b/kernel/trace/trace_branch.c
@@ -379,7 +379,7 @@ __init static int all_annotated_branch_stats(void)
int ret;
ret = register_stat_tracer(&all_branch_stats);
- if (!ret) {
+ if (ret) {
printk(KERN_WARNING "Warning: could not register "
"all branches stats\n");
return 1;
--
1.6.3.1
--
next prev parent reply other threads:[~2009-06-04 5:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 5:25 [PATCH 0/6] [GIT PULL] tracing/branch-profiler: per cpu and other things Steven Rostedt
2009-06-04 5:25 ` [PATCH 1/6] tracing/function-profiler: do not free per cpu variable stat Steven Rostedt
2009-06-04 5:25 ` Steven Rostedt [this message]
2009-06-04 5:25 ` [PATCH 3/6] tracing/branch-profiler: do not profile managers Steven Rostedt
2009-06-04 5:25 ` [PATCH 4/6] tracing/branch-profiler: move macro defines to kernel.h Steven Rostedt
2009-06-04 5:25 ` [PATCH 5/6] tracing/branch-profiling: add variable to disable branch profiling Steven Rostedt
2009-06-04 5:25 ` [PATCH 6/6] tracing/branch-profiler: add option to profile branches per cpu Steven Rostedt
2009-06-06 7:31 ` [PATCH 0/6] [GIT PULL] tracing/branch-profiler: per cpu and other things Ingo Molnar
2009-06-06 14:37 ` [PATCH] tracing/branch-tracer: PROFILE_BRANCHES_PER_CPU must depend on SMP Frederic Weisbecker
2009-06-06 14:42 ` Steven Rostedt
2009-06-06 14:56 ` Frederic Weisbecker
2009-06-07 13:44 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604052613.005013632@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox