Re: [GIT PULL] headers_check fixes

Russell King
2009-06-06T13:42:12Z

On Sat, Jun 06, 2009 at 07:04:37PM +0530, Jaswinder Singh Rajput wrote:
> On Sat, 2009-06-06 at 14:02 +0100, Russell King wrote:
> > On Sat, Jun 06, 2009 at 06:24:17PM +0530, Jaswinder Singh Rajput wrote:
> > > Linus,
> > >
> > > Please pull headers_check fixes:
> > >
> > > The following changes since commit 064e38aaded5269e573ac1c765284fd65c8ebd13:
> > > Linus Torvalds (1):
> > > Merge git://git.kernel.org/.../mason/btrfs-unstable
> > >
> > > are available in the git repository at:
> > >
> > > git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master
> > >
> > > Jaswinder Singh Rajput (6):
> > > headers_check fix: arm, hwcap.h
> >
> > So inspite of NAKing this patch you send it anyway.
> >
>
> Earlier it was already like this, because of Catalin Marinas
> fault (commit f884b1cf578e0) and your ignorance you converted :
>
> #ifdef __KERNEL__
> #ifndef __ASSEMBLY__
>
> to :
>
> #if defined(__KERNEL__) && !defined(__ASSEMBLY__)
>
> I am just trying to rectify your mistake that __KERNEL__ should not be
> used with other defines to easily export headers to userspace. Whole
> kernel header files are following this protocol. Sam, Arnd and me are
> trying to convince you. Why you need an exception ?

You are not listening.

I believe that there is a much better way to fix this, and that is to
fix the tools. Having looked at unifdef, I believe that the fix is
almost trivial in nature.

With fixed tools, we don't have to fuck around writing a special dialect
of C to work around their short comings - a dialect which isn't obvious.

What we actually have here is a small number of people who've suddenly
decided that a perfectly good bit of C code is no longer good enough for
their purposes, and are now requiring things to be written to match their
own rules.

Let's fix the tools and then we don't have to ever worry about this
problem again, or require people to write their C code in special ways.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/