Re: [PATCH 0/6] headers_check fix patches 20090604

Sam Ravnborg
2009-06-04T20:10:37Z

On Thu, Jun 04, 2009 at 05:53:52PM +0530, Jaswinder Singh Rajput wrote:
> Please Review :
>
> Jaswinder Singh Rajput (6):
> headers_check fix: arm, hwcap.h
> headers_check fix: ia64, fpswa.h
> headers_check fix: m68k, swab.h
> headers_check fix: mips, ioctl.h
> headers_check fix: mn10300, ptrace.h
> headers_check fix: mn10300, setup.h

Please let the subject explain what was fixed.
The fact that you used headers_check to detect the
issue in the first place is less relevant.

For mips the subject could have been:

mips: use userspace compatible definition of _IOC_TYPECHECK

Did you concentrate solely on headers_check output
or did you carefully inspect the files you touched for userspace issues?
I stroingly recommend to fix all userspace issues in files touched
if this is possible.

Sam