* mmotm 2009-06-03-16-33 uploaded @ 2009-06-03 23:33 akpm 2009-06-04 3:38 ` sysfs_create_link_nowarn still remains (Was " KAMEZAWA Hiroyuki 0 siblings, 1 reply; 5+ messages in thread From: akpm @ 2009-06-03 23:33 UTC (permalink / raw) To: mm-commits, linux-kernel The mm-of-the-moment snapshot 2009-06-03-16-33 has been uploaded to http://userweb.kernel.org/~akpm/mmotm/ and will soon be available at git://git.zen-sources.org/zen/mmotm.git It contains the following patches against 2.6.30-rc8: ptrace-tracehook_report_clone-fix-false-positives.patch char-mxser-fix-isa-board-lookup.patch kbuild-fix-detection-of-config_frame_warn=0.patch ptrace-revert-ptrace_detach-the-wrong-wakeup-breaks-the-erestartxxx-logic.patch revert-fbdev-fix-info-lock-deadlock-in-fbcon_event_notify.patch revert-fbdev-uninline-lock_fb_info.patch revert-fbmem-fix-fb_info-lock-and-mm-mmap_sem-circular-locking-dependency.patch revert-fbmem-dont-call-copy_from-to_user-with-mutex-held.patch fbdev-move-back-to-bkl-solution.patch epoll-send-pollhup-on-release.patch repeatable-slab-corruption-with-ltp-msgctl08.patch linux-next.patch next-remove-localversion.patch i-need-old-gcc.patch ds_selftest-is-borked.patch sound-core-initc-fix-deadlock.patch dell-wmi-mask-off-bis-provided-garbage-in-scancode-data.patch arch-x86-kernel-cpu-cpufreq-acpi-cpufreqc-avoid-cross-cpu-interrupts.patch x86-enable-gart-iommu-only-after-setting-up-protection-methods.patch x86-apic-io_apicc-dmar_msi_type-should-be-static.patch x86-nmi-add-intel-processor-0x6f4-to-nmi-perfctr1-workaround.patch agpgart-detected-ali-m-chipset-with-m1621.patch s3c-fix-check-of-index-into-s3c_gpios.patch cpufreq-powernow-k8-cleanup-msg-if-bios-does-not-export-acpi-_pss-cpufreq-data-cleanup.patch pcmcia-yenta-add-missing-__devexit-marking.patch pcmcia-pccard-deadlock-fix.patch drivers-hvc-add-missing-__devexit_p.patch doc-add-documentation-for-debugfs.patch devres-warn-and-return-dont-crash-on-device_del-of-uninitialized-device.patch devres-warn-and-return-dont-crash-on-device_del-of-uninitialized-device-cleanup.patch drm-fix-lock_test_with_return-macro.patch intelfb-fix-spelling-of-clock.patch drm-simplify-kcalloc-call-to-kzalloc.patch drm-intel-add-ignore-lvds-quirk-info-for-aopen-mini-pc.patch radio-mr800c-missing-mutex-include.patch dvb-core-fix-potential-mutex_unlock-without-mutex_lock-in-dvb_dvr_read.patch vino-replace-dma_sync_single-with-dma_sync_single_for_cpu.patch v4l-pwc-use-usb_interface-as-parent-not-usb_device.patch v4l-generate-key_camera-instead-of-btn_0-key-events-on-input-devices.patch time-move-pit_tick_rate-to-linux-timexh.patch clocksource-disallow-setting-jiffies-as-the-clocksource.patch clocksource-sanity-check-sysfs-clocksource-changes.patch ia64-remove-obsolete-no_irq_type.patch ia64-remove-obsolete-irq_desc_t-typedef.patch ia64-remove-obsolete-hw_interrupt_type.patch ia64-msi_ia64c-dmar_msi_type-should-be-static.patch ib-mthca-replace-dma_sync_single-with-dma_sync_single_for_cpu.patch input-mouse-alpsc-handle-touchpoints-buttons-correctly.patch ads7846-pin-change-interrupt-support.patch input-drivers-input-xpadc-improve-xbox-360-wireless-support-and-add-sysfs-interface.patch input-documentation-input-xpadtxt-update-for-new-driver-functionality.patch input-add-wm97xx-accelerated-driver-for-avr32-at32ap700x-microprocessors.patch kernel-kallsymsc-replace-deprecated-__initcall-with-device_initcall-and-fix-whitespace.patch menu-fix-embedded-menu-presentation.patch scripts-headers_checkpl-correct-re-in-header-config-leak-check.patch remove-bashisms-from-scripts.patch kbuild-fix-a-compile-warning.patch kconfig-fix-typo-mconfig-to-menuconfig-in-a-comment.patch kconfig-add-a-note-about-the-deps-to-the-silentoldconfig-help.patch kconfig-resort-the-documentation-of-the-environment-variables.patch gitignore-ignore-kconfig-i18n-files.patch kconfig-qconf-fix-wall-compiler-warnings.patch kconfig-qconf-fix-namespace-for-horizontal-and-vertical-enum-values.patch kconfig-qconf-add-namespace-for-use-of-key_-enum-values.patch kconfig-qconf-fix-the-type-of-the-desktop-widget.patch kconfig-do-not-hardcode-config-filename.patch kconfig-do-not-hardcode-include-config-autoconf-filename.patch scripts-allow-docproc-invocation-from-external.patch leds-fix-led-bd2802-errors-while-resuming.patch leds-change-the-license-information.patch leds-add-the-sysfs-interface-into-the-leds-bd2802-driver-for-changing-wave-pattern-and-led-current.patch drivers-leds-leds-gpioc-fix-a-section-mismatch.patch leds-alix-leds2-fixed-for-award-bios.patch microblaze-remove-unused-flat_stack_align-definition.patch txx9dmac-use-dma_unmap_single-if-dma_compl_srcdest_unmap_single-was-set.patch mmc-align-data-size-for-host-which-only-supports-power-of-2-block.patch mmc-in-mmc_power_up-use-previously-selected-ocr-if-available.patch omap-hsmmc-do-not-enable-buffer-ready-interrupt-if-using-dma.patch mmc_spi-use-eilseq-for-possible-transmission-errors.patch mtd-flex-onenand-support.patch mtd-onenand-add-bbt_wait-unlock_all-as-replaceable-for-some-platform.patch mtd-plat_nand-add-platform-probe-remove-callbacks.patch mtd-plat_nand-allow-platform-to-set-partitions.patch mtd-nand-dont-walk-past-end-of-oobfree.patch mtd-nand-minor-davinci_nand-cleanup.patch mtd-nand-davinci_nand-4-bit-ecc-for-smallpage.patch mtd-add-omap2-omap3-nand-driver.patch mtd-remove-pmcmsp-ramrootc.patch mtd-add-sst39sf040-chip-to-jedec_probe.patch davinci_nand-cmdlinepart-uses-mtd-ids.patch plat_nand-add-missing-__devexit_p.patch jffs2-move-jffs2_gcd_mtd-threads-to-the-new-kthread-api.patch jffs2-jffs2_start_garbage_collect_thread-return-value-cleanup.patch sunrpc-align-cache_clean-works-timer.patch irda-new-blackfin-on-chip-sir-irda-driver.patch irda-count-reaches-1.patch drivers-isdn-i4l-isdn_ttyc-fix-check-for-array-overindexing.patch de2104x-support-for-systems-lacking-cache-coherence.patch drivers-net-macvlanc-fix-cloning-of-tagged-vlan-interfaces.patch atl1c-wake_mcast-tested-twice-not-wake_ucast.patch forcedeth-fix-mac-address-detection-on-network-card-regression-in-2623.patch e1000e-make-e1000e-default-to-the-same-kconfig-setting-as-e1000.patch 3x59x-fix-pci-resource-management.patch da9030_battery-fix-race-between-event-handler-and-monitor.patch parisc-remove-obsolete-hw_interrupt_type.patch pci-quirks-hp-hides-smbus-controller-in-compaq-nx9500-laptops.patch pci-quirks-unhide-overflow-device-on-i828675p-pe-chipsets-v2.patch pci-eliminate-redundant-pci_stop_dev-call-from-pci_destroy_dev.patch pci-pm-follow-pci_pm_ctrl_no_soft_reset-during-transitions-from-d3.patch pci-pm-read-device-power-state-from-register-after-updating-it.patch pci-pm-read-device-power-state-from-register-after-updating-it-update.patch scsi-use-the-common-hex_asc-array-rather-than-a-private-one.patch scsi-gdthc-use-unaligned-access-helpers.patch scsi-annotate-gdth_rdcap_data-gdth_rdcap16_data-endianness.patch sg_io-dont-perform-unneeded-copy-in-compat-code.patch scsi-ncr53c8xx-div-reaches-1.patch qla2x-fix-printk-format-warnings.patch scsi-pcmcia-nsp_cs-time_out-reaches-1.patch block-prevent-possible-io_context-refcount-overflow.patch fs-bioc-add-missing-__user-annotation.patch ramdisk-remove-long-deprecated-ramdisk=-boot-time-param.patch floppy-fix-hibernation.patch sparc-move-the-duplication-in-dma-mapping_3264h-to-dma-mappingh.patch sparc-add-sync_single_for_device-and-sync_sg_for_device-to-struct-dma_ops.patch sparc-use-dma_map_page-instead-of-dma_map_single.patch sparc-remove-dma-mapping_3264h.patch vfs-fix-vfs_rename_dir-for-fs_rename_does_d_move-filesystems.patch raw-fix-rawctl-compat-ioctls-breakage-on-amd64-and-itanic.patch vfs-improve-comment-describing-fget_light.patch libfs-make-simple_read_from_buffer-conventional.patch fs-inodec-add-dev-id-and-inode-number-for-debugging-in-init_special_inode.patch fs-fix-lock-imbalance-in-do_remount_sb.patch mac80211-use-kzfree-in-key-handling-to-enforce-data-sanitization.patch xtensa-variant-specific-code.patch xtensa-cache-inquiry-and-unaligned-cache-handling-functions.patch xtensa-s6000-dma-engine-support.patch xtensa-allow-platform-and-variant-to-initialize-own-irq-chips.patch xtensa-support-s6000-gpio-irqs-and-alternate-function-selection.patch s6gmac-xtensa-s6000-on-chip-ethernet-driver.patch xtensa-s6105-specific-configuration-for-s6gmac.patch xtensa-enable-s6gmac-in-s6105_defconfig.patch xtensa-add-m41t62-rtc-to-s6105-platform.patch xtensa-enable-m41t80-driver-in-s6105_defconfig.patch lguest-fix-array-indexing-check.patch virtio_blk-add-missing-__devinitexit-markings.patch mm.patch mm-disable-preemption-in-apply_to_pte_range.patch rtc-add-ds1685-ds1687-rtc-driver.patch ext2-add-blk_issue_flush-to-syncing-paths.patch scsi-dpt_i2o-is-bust-on-ia64.patch intelfb-fix-color-map-setting-with-an-lvds-display.patch pci-use-fixed-up-device-class-when-configuring-device.patch drivers-rtc-rtc-cmosc-cmos_init-dont-ignore-pnp_register_driver-return-value.patch x86-fix-cpufreq-tsc-scaling.patch mm-consolidate-init_mm-definition.patch mm-consolidate-init_mm-definition-fix.patch readahead-make-mmap_miss-an-unsigned-int.patch readahead-move-max_sane_readahead-calls-into-force_page_cache_readahead.patch readahead-apply-max_sane_readahead-limit-in-ondemand_readahead.patch readahead-remove-one-unnecessary-radix-tree-lookup.patch readahead-increase-interleaved-readahead-size.patch readahead-remove-sync-async-readahead-call-dependency.patch readahead-clean-up-and-simplify-the-code-for-filemap-page-fault-readahead.patch readahead-sequential-mmap-readahead.patch readahead-enforce-full-readahead-size-on-async-mmap-readahead.patch readahead-record-mmap-read-around-states-in-file_ra_state.patch readahead-record-mmap-read-around-states-in-file_ra_state-checkpatch-fixes.patch radix-tree-add-radix_tree_prev_hole.patch readahead-move-the-random-read-case-to-bottom.patch readahead-introduce-context-readahead-algorithm.patch readahead-introduce-context-readahead-algorithm-update.patch readahead-remove-redundant-test-in-shrink_readahead_size_eio.patch readahead-enforce-full-sync-mmap-readahead-size.patch mm-clean-up-get_user_pages_fast-documentation.patch mm-clean-up-get_user_pages_fast-documentation-checkpatch-fixes.patch vmscan-low-order-lumpy-reclaim-also-should-use-pageout_io_sync.patch mm-page-writebackc-dirty-limit-type-should-be-unsigned-long.patch ksm-mmu_notifiers-add-set_pte_at_notify.patch ksm-add-get_pte-helper-function-fetching-pte-for-va.patch ksm-add-get_pte-helper-function-fetching-pte-for-va-fix.patch ksm-add-page_wrprotect-write-protecting-page.patch ksm-add-replace_page-change-the-page-pte-is-pointing-to.patch ksm-add-ksm-kernel-shared-memory-driver.patch ksm-add-ksm-kernel-shared-memory-driver-checkpatch-fixes.patch ksm-add-ksm-kernel-shared-memory-driver-fix-unsafe-pte-fetching.patch ksm-add-ksm-kernel-shared-memory-driver-fix.patch ksm-add-ksm-kernel-shared-memory-driver-limiting-the-num-of-mem-regions-user-can-register-per-fd.patch ksm-add-ksm-kernel-shared-memory-driver-dont-allow-overlap-memory-addresses-registrations.patch ksm-add-ksm-kernel-shared-memory-driver-change-the-ksm_remove_memory_region-ioctl.patch ksm-add-ksm-kernel-shared-memory-driver-change-the-prot-handling-to-use-the-generic-helper-functions.patch ksm-add-ksm-kernel-shared-memory-driver-use-another-miscdevice-minor-number.patch ksm-add-ksm-kernel-shared-memory-driver-ksm-fix-rmap_item-use-after-free.patch ksm-add-replace_page-change-the-page-pte-is-pointing-to-fix-losing-visibility-of-part-of-rmap_item-next-list.patch cpusets-restructure-the-function-cpuset_update_task_memory_state.patch cpusets-update-tasks-page-slab-spread-flags-in-time.patch cpusetmm-update-tasks-mems_allowed-in-time.patch cpusetmm-update-tasks-mems_allowed-in-time-fix.patch cpusetmm-update-tasks-mems_allowed-in-time-cleanup.patch mm-alloc_large_system_hash-check-order.patch page-allocator-replace-__alloc_pages_internal-with-__alloc_pages_nodemask.patch page-allocator-do-not-sanity-check-order-in-the-fast-path.patch page-allocator-do-not-sanity-check-order-in-the-fast-path-fix.patch page-allocator-do-not-check-numa-node-id-when-the-caller-knows-the-node-is-valid.patch page-allocator-check-only-once-if-the-zonelist-is-suitable-for-the-allocation.patch page-allocator-break-up-the-allocator-entry-point-into-fast-and-slow-paths.patch page-allocator-move-check-for-disabled-anti-fragmentation-out-of-fastpath.patch page-allocator-calculate-the-preferred-zone-for-allocation-only-once.patch page-allocator-calculate-the-preferred-zone-for-allocation-only-once-fix.patch page-allocator-calculate-the-migratetype-for-allocation-only-once.patch page-allocator-calculate-the-alloc_flags-for-allocation-only-once.patch page-allocator-remove-a-branch-by-assuming-__gfp_high-==-alloc_high.patch page-allocator-inline-__rmqueue_smallest.patch page-allocator-inline-buffered_rmqueue.patch page-allocator-inline-__rmqueue_fallback.patch page-allocator-do-not-call-get_pageblock_migratetype-more-than-necessary.patch page-allocator-do-not-disable-interrupts-in-free_page_mlock.patch page-allocator-do-not-setup-zonelist-cache-when-there-is-only-one-node.patch page-allocator-do-not-check-for-compound-pages-during-the-page-allocator-sanity-checks.patch page-allocator-use-allocation-flags-as-an-index-to-the-zone-watermark.patch page-allocator-use-allocation-flags-as-an-index-to-the-zone-watermark-replace-the-watermark-related-union-in-struct-zone-with-a-watermark-array.patch page-allocator-update-nr_free_pages-only-as-necessary.patch page-allocator-update-nr_free_pages-only-as-necessary-fix.patch page-allocator-get-the-pageblock-migratetype-without-disabling-interrupts.patch page-allocator-use-a-pre-calculated-value-instead-of-num_online_nodes-in-fast-paths.patch page-allocator-use-a-pre-calculated-value-instead-of-num_online_nodes-in-fast-paths-do-not-override-definition-of-node_set_online-with-macro.patch page-allocator-slab-use-nr_online_nodes-to-check-for-a-numa-platform.patch page-allocator-move-free_page_mlock-to-page_allocc.patch page-allocator-sanity-check-order-in-the-page-allocator-slow-path.patch mm-use-alloc_pages_exact-in-alloc_large_system_hash-to-avoid-duplicated-logic.patch mm-introduce-pagehuge-for-testing-huge-gigantic-pages.patch mm-introduce-pagehuge-for-testing-huge-gigantic-pages-update.patch proc-kpagecount-kpageflags-code-cleanup.patch proc-export-more-page-flags-in-proc-kpageflags.patch pagemap-document-clarifications.patch pagemap-document-9-more-exported-page-flags.patch pagemap-add-page-types-tool.patch pagemap-add-page-types-tool-fix.patch pagemap-export-pg_hwpoison.patch pagemap-export-pg_hwpoison-fix.patch vmscan-evict-use-once-pages-first-v3.patch vmscan-cleanup-the-scan-batching-code.patch vmscan-dont-export-nr_saved_scan-in-proc-zoneinfo.patch vmscan-zvc-updates-in-shrink_active_list-can-be-done-once.patch mm-setup_per_zone_inactive_ratio-do-not-call-for-int_sqrt-if-not-needed.patch mm-setup_per_zone_inactive_ratio-fix-comment-and-make-it-__init.patch mm-introduce-follow_pte.patch mm-use-generic-follow_pte-in-follow_phys.patch mm-introduce-follow_pfn.patch videobuf-dma-contig-zero-copy-userptr-support-v3.patch videobuf-dma-contig-zero-copy-userptr-support-v3-comments.patch videobuf-dma-contig-zero-copy-userptr-support-v3-comments-checkpatch-fixes.patch page-allocator-warn-if-__gfp_nofail-is-used-for-a-large-allocation.patch mm-madvise-correct-return-code.patch mm-pm-freezer-disable-oom-killer-when-tasks-are-frozen.patch vmscan-change-the-number-of-the-unmapped-files-in-zone-reclaim.patch vmscan-drop-pf_swapwrite-from-zone_reclaim.patch vmscan-zone_reclaim-use-may_swap.patch migration-only-migrate_prep-once-per-move_pages.patch vmscan-prevent-shrinking-of-active-anon-lru-list-in-case-of-no-swap-space-v3.patch mm-check-the-argument-of-kunmap-on-architectures-without-highmem.patch page-allocator-use-integer-fields-lookup-for-gfp_zone-and-check-for-errors-in-flags-passed-to-the-page-allocator.patch page-allocator-use-integer-fields-lookup-for-gfp_zone-and-check-for-errors-in-flags-passed-to-the-page-allocator-fix-gfp-zone-patch.patch page-allocator-clean-up-functions-related-to-pages_min.patch page-allocator-clean-up-functions-related-to-pages_min-checkpatch-fixes.patch page-allocator-add-inactive-ratio-calculation-function-of-each-zone.patch page-allocator-add-inactive-ratio-calculation-function-of-each-zone-checkpatch-fixes.patch page-allocator-reset-wmark_min-and-inactive-ratio-of-zone-when-hotplug-happens.patch mm-remove-config_unevictable_lru-config-option.patch mm-add-swap-cache-interface-for-swap-reference.patch mm-modify-swap_map-and-add-swap_has_cache-flag.patch mm-modify-swap_map-and-add-swap_has_cache-flag-update.patch mm-reuse-unused-swap-entry-if-necessary.patch mm-reuse-unused-swap-entry-if-necessary-update.patch readahead-add-blk_run_backing_dev.patch readahead-add-blk_run_backing_dev-fix.patch readahead-add-blk_run_backing_dev-fix-fix-2.patch oom-move-oom_adj-value-from-task_struct-to-mm_struct.patch oom-move-oom_adj-value-from-task_struct-to-mm_struct-fix.patch oom-avoid-unnecessary-mm-locking-and-scanning-for-oom_disable.patch oom-invoke-oom-killer-for-__gfp_nofail.patch mm-remove-__invalidate_mapping_pages-variant.patch frv-remove-in-kernel-strace-code.patch frv-implement-tif_notify_resume.patch frv-dont-turn-on-tif_syscall_trace-unconditionally-in-syscall-prologue.patch frv-implement-new-style-ptrace.patch frv-duplicate-output_buffer-of-e03.patch frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch alpha-remove-obsolete-hw_interrupt_type.patch alpha-bad-macro-expansion-parameter-is-member.patch m32r-remove-obsolete-hw_interrupt_type.patch m68k-count-can-reach-51-not-50.patch m68k-cnt-reaches-1-not-0.patch uml-uml-net-driver-does-not-allow-for-vlans.patch um-remove-obsolete-hw_interrupt_type.patch uml-fix-a-section-warning.patch uml-bad-macro-expansion-parameter-is-member.patch slow_work_thread-should-do-the-exclusive-wait.patch rework-fix-is_single_threaded.patch utsnameh-make-new_utsname-fields-use-the-proper-length-constant.patch atomic-only-take-lock-when-the-counter-drops-to-zero-on-up-as-well.patch kernel-kfifoc-replace-conditional-test-with-is_power_of_2.patch ntfs-use-is_power_of_2-function-for-clarity.patch poll-avoid-extra-wakeups-in-select-poll.patch headers-move-module_bug_finalize-module_bug_cleanup-definitions-into-moduleh.patch drbd-add-major-number-to-majorh.patch remove-put_cpu_no_resched.patch remove-put_cpu_no_resched-fix.patch groups-move-code-to-kernel-groupsc.patch lib-do-code-optimization-for-radix_tree_lookup-and-radix_tree_lookup_slot.patch lib-do-code-optimization-for-radix_tree_lookup-and-radix_tree_lookup_slot-update.patch use-round_jiffies-for-slow-work-thread-pools-cull-and-oom-timers.patch use-printk_once-in-several-places.patch use-printk_once-in-several-places-clean-up-printk_once-of-get_cpu_vendor.patch hexdump-remove-the-trailing-space.patch documentation-accounting-getdelaysc-intialize-the-variable-before-using-it.patch kmap_types-make-most-arches-use-generic-header-file.patch syscallsh-remove-duplicated-declarations-for-sys_pipe2.patch eisaids-add-network-peripherals-fddi-boards.patch documentation-atomic_opstxt-fix-sample-code.patch gitignore-ignore-patch-files.patch scripts-get_maintainerpl-output-first-field-only-in-mailing-lists-and-after-maintainers.patch scripts-get_maintainerpl-better-fix-for-subscriber-only-mailing-lists.patch scripts-get_maintainerpl-improve-git-chief-penquins-linus-torvalds-filtering.patch scripts-get_maintainerpl-warn-on-missing-git-or-git-repository.patch scripts-get_maintainerpl-support-m-lines-with-names-and-multiple-entries-per-m-line.patch scripts-get_maintainerpl-better-email-name-quoting.patch scripts-get_maintainerpl-support-both-p-m-and-integrated-m-lines.patch scripts-get_maintainerpl-dont-print-maintainers-when-not-requested.patch scripts-get_maintainerpl-allow-8-bit-characters-in-email-addresses.patch scripts-get_maintainerpl-change-die-to-warn-when-command-line-file-is-not-a-patch.patch maintainers-swap-mismarked-ecrypt-fs-m-and-p-entries.patch maintainers-add-file-patterns-to-the-rest.patch maintainers-update-m32r-file-patterns-after-rename.patch maintainers-mark-alsa-lists-as-moderated.patch maintainers-remove-l-linux-kernel-vgerkernelorg-from-all-but-the-rest.patch maintainers-mention-scripts-get_maintainerpl-in-the-preface.patch maintainers-add-file-pattern-to-cisco-fcoe-hba-driver.patch maintainers-add-paul-mckenney-to-rcu-and-rcutorture.patch maintainers-add-file-patterns-to-tty-layer.patch getrusage-fill-ru_maxrss-value.patch rb_tree-reorganize-code-in-rb_erase-for-additional-changes.patch rb_tree-reorganize-code-in-rb_erase-for-additional-changes-checkpatch-fixes.patch rb_tree-make-clear-distinction-between-two-different-cases-in-rb_erase.patch rb_tree-remove-redundant-if-condition-in-rb_erase.patch softirq-introduce-statistics-for-softirq.patch irqs-add-irqf_sample_random-to-the-feature-removal-scheduletxt-deprecated-list.patch proc-export-statistics-for-softirq-to-proc.patch proc-update-document-for-proc-softirqs-and-proc-stat.patch drivers-hwmon-coretempc-enable-the-intel-atom.patch lis3-fix-misc-device-unregistering-and-printk.patch lis3-remove-automatic-shutdown-of-the-device.patch lis3-use-input_polled_device.patch lis3-use-input_polled_device-fix.patch lis3-add-three-new-laptop-models.patch fs-remove-sparse-errors-in-proc_devtreec.patch proc-merge-arrayc-into-basec.patch proc-merge-arrayc-into-basec-checkpatch-fixes.patch pci-use-pci_ioremap_bar-in-drivers-serial.patch kgdb-kgdboc-console-poll-hooks-for-serial_txx9-uart.patch serial_txx9-use-container_of-instead-of-direct-cast.patch icom-converting-space-to-tabs.patch serial-8250c-irq-handling-race-and-spurious-iir-read.patch serial-z85c30-bcm1480-loops-reach-1.patch jsm-clean-up-serial-jsm-correctly-support-4-8-port-boards.patch serial-add-parameter-to-force-skipping-the-test-for-the-txen-bug.patch spi_bfin5xx-limit-reaches-1.patch spi-move-common-spi_setup-functionality-into-core.patch spi-move-more-spi_setup-functionality-into-core.patch mpc52xx_psc_spi-convert-to-cs_control-callback.patch pxa2xx_spi-fix-for-spi_cs_high.patch spi-fix-spi_write_then_read-comment.patch spi_mpc83xx-handle-other-freescale-processors.patch spi_mpc83xx-quieten-down-the-requested-speed-is-too-low-message.patch spi_mpc83xx-add-small-delay-after-asserting-chip-select-line.patch powerpc-86xx-add-mmc-spi-support-for-mpc8610hpcd-boards.patch spi_mpc83xx-fix-checkpatch-issues.patch spi_mpc83xx-split-mpc83xx_spi_work-into-two-routines.patch spi_mpc83xx-remove-dead-code.patch spi_mpc83xx-rename-spi_83xxc-to-spi_8xxxc.patch spi_mpc8xxx-s-83xx-8xxx-g.patch sunrpc-use-formatting-of-module-name-in-sunrpc.patch rtc-rtc-ds1742-nvram-attribute-fix.patch rtc-rtc-ds1307-add-ds1388.patch rtc-rtc-ds1307-add-ds3231.patch rtc-add-stand-alone-driver-for-rx8025-chip.patch rtc-add-stand-alone-driver-for-rx8025-chip-fix.patch rtc-tx4939-drop-irqf_shared.patch rtc-ds1553-drop-irqf_shared.patch drivers-char-rtc-disable-legacy-rtc-driver-on-blackfin-systems.patch rtc-make-rtc_update_irq-callable-with-irqs-enabled-v2.patch pca953x-support-gpiolib-gpio-naming.patch gpio-max7301-add-missing-__devexit-marking.patch gpio-driver-for-primecell-pl061-gpio-controller.patch gpio-driver-for-primecell-pl061-gpio-controller-fix.patch gpio-driver-for-primecell-pl061-gpio-controller-fix-fix.patch fbdev-generated-logo-sources-depend-on-scripts-pnmtologo.patch fbdev-move-logo-externs-to-header-file.patch fbdev-add-video-modes-for-resolutions-and-timings-of-pal-rgb.patch documentation-fb-vesafbtxt-fix-typo.patch chipsfb-remove-redundant-assignment.patch igafb-use-framebuffer_alloc-to-allocate-fb_info-struct.patch offb-use-framebuffer_alloc-to-allocate-fb_info-struct.patch atmel-lcdc-fix-pixclock-upper-bound-detection.patch samsung-soc-framebuffer-driver-add-alpha-channel-support.patch mb862xxfb-restrict-compliation-of-platform-driver-to-ppc.patch mb862xxfb-use-config_of-instead-of-config_ppc_of.patch acornfb-remove-fb_mmap-function.patch carminefb-fix-possible-access-beyond-end-of-carmine_modedb.patch s3c-fb-fix-resource-releasing-on-error-during-probing.patch s3c-fb-cpufreq-frequency-scaling-support.patch radeon-p2g2clk_always_onb-tested-twice-should-2nd-be-p2g2clk_dac_always_onb.patch radeon-p2g2clk_always_onb-tested-twice-should-2nd-be-p2g2clk_dac_always_onb-fix.patch fbdev-use-framebuffer_release-for-freeing-fb_info-structures.patch platinumfb-misplaced-parenthesis.patch intelfb-fix-setting-of-active-pipe-with-lvds-displays.patch intelfb-fix-a-bug-when-changing-video-timing.patch bw2-use-standard-fields-for-framebuffer-physical-address-and-length.patch cg14-use-standard-fields-for-framebuffer-physical-address-and-length.patch cg3-use-standard-fields-for-framebuffer-physical-address-and-length.patch cg6-use-standard-fields-for-framebuffer-physical-address-and-length.patch leo-use-standard-fields-for-framebuffer-physical-address-and-length.patch p9100-use-standard-fields-for-framebuffer-physical-address-and-length.patch tcx-use-standard-fields-for-framebuffer-physical-address-and-length.patch ext2-do-not-update-mtime-of-a-moved-directory.patch doc-fix-ext2-can-only-have-32000-subdirs-not-32768.patch ext3-fix-chain-verification-in-ext3_get_blocks.patch isofs-let-mode-and-dmode-mount-options-override-rock-ridge-mode-setting.patch isofs-fix-setting-of-uid-and-gid-to-0.patch isofs-cleanup-mount-option-processing.patch hfsplus-identify-journal-info-block-in-volume-header.patch hfsplus-fix-journal-detection.patch ufs-sector_t-cannot-be-negative.patch documentation-changes-perl-is-needed-to-build-the-kernel.patch documentation-changes-perl-is-needed-to-build-the-kernel-fix.patch documentation-connector-cn_testc-comment-unused-cn_test_want_notify.patch cgroups-make-messages-more-readable.patch cgroups-forbid-noprefix-if-mounting-more-than-just-cpuset-subsystem.patch cgroups-forbid-noprefix-if-mounting-more-than-just-cpuset-subsystem-fix.patch cgroups-forbid-noprefix-if-mounting-more-than-just-cpuset-subsystem-fix2.patch devcgroup-skip-superfluous-checks-when-found-the-dev_all-elem.patch memcg-add-file-based-rss-accounting.patch memcg-add-file-based-rss-accounting-fix-mem_cgroup_update_mapped_file_stat-oops.patch memcg-remove-mem_cgroup_cache_charge_swapin.patch memcg-remove-some-redundant-checks.patch memcg-remove-unneeded-forward-declaration-from-schedh.patch memcg-fix-swap-accounting.patch memcg-fix-swap-accounting-update.patch allow_signal-kill-the-bogus-mm-check-add-a-note-about-clone_sighand.patch ptrace-remove-pt_dtrace-from-arch-h8300.patch ptrace-remove-pt_dtrace-from-avr32-mn10300-parisc-s390-sh-xtensa.patch ptrace-remove-pt_dtrace-from-m68k-m68knommu.patch ptrace-remove-pt_dtrace-from-arch-m32r.patch ptrace-mm_need_new_owner-use-real_parent-to-search-in-the-siblings.patch ptrace-tracehook_unsafe_exec-remove-the-stale-comment.patch ptrace-tracehook_unsafe_exec-remove-the-stale-comment-fix.patch ptrace-do-not-use-task-ptrace-directly-in-core-kernel.patch ptrace-ptrace_attach-check-pf_kthread-exit_state-instead-of-mm.patch ptrace-cleanup-check-set-of-pt_ptraced-during-attach.patch ptrace-do-not-use-task_lock-for-attach.patch ptrace_get_task_struct-s-tasklist-rcu-make-it-static.patch ptrace-wait_task_zombie-s-parent-real_parent.patch ptrace-do_notify_parent_cldstop-fix-the-wrong-nsproxy-usage.patch ptrace-dont-take-tasklist-to-get-set-last_siginfo.patch signals-tracehook_notify_jctl-change.patch utrace-core.patch copy_process-remove-the-unneeded-clear_tsk_thread_flagtif_sigpending.patch elf_core_dump-use-rcu_read_lock-to-access-real_parent.patch shift-ptrace-implies-wuntraced-from-ptrace_do_wait-to-wait_task_stopped.patch introduce-struct-wait_opts-to-simplify-do_wait-pathes.patch do_wait-simplify-retval-tsk_result-notask_error-mess.patch do_wait-kill-the-old-bug_on-use-while_each_thread.patch do_wait-fix-the-theoretical-race-with-stop-trace-cont.patch mm-exitc-reorder-wait_opts-to-remove-padding-on-64-bit-builds.patch wait_task_-cleanups-split-wait_noreap_copyout.patch wait_task_-cleanups-use-copy_wait_opts_to_user-in-wait_task_stopped.patch wait_task_-cleanups-use-copy_wait_opts_to_user-in-do_wait.patch wait_task_-cleanups-use-copy_wait_opts_to_user-in-wait_task_zombie.patch wait_task_-cleanups-use-copy_wait_opts_to_user-in-wait_task_continued.patch kthreads-simplify-the-startup-synchronization.patch kthreads-rework-kthread_stop.patch kthreads-simplify-migration_thread-exit-path.patch ipc-use-__arch_want_ipc_parse_version-in-ipc-utilh.patch drivers-char-memc-memory_open-cleanup-lookup-minor-device-number-from-devlist.patch drivers-char-memc-memory_open-cleanup-lookup-minor-device-number-from-devlist-checkpatch-fixes.patch char-isicom-fix-build-warning.patch dtlk-off-by-one-in-readwrite_tts.patch istallion-add-missing-__devexit-marking.patch ppdev-reduce-kernel-log-spam.patch rapidio-add-common-mapping-apis-for-rapidio-memory-access.patch powerpc-add-memory-map-support-to-freescale-rapidio-block.patch rionet-add-memory-access-to-simulated-ethernet-over-rapidio.patch rio-warn_unused_result-warnings-fix.patch rapidio-fix-kerneldoc-for-rio_mem_ops.patch sysctlc-remove-unused-variable.patch pids-clean-up-find_task_by_pid-variants.patch pidns-make-create_pid_namespace-accept-parent-pidns.patch pidns-rewrite-copy_pid_ns.patch utsns-extract-creeate_uts_ns.patch ipcns-remove-useless-get-put-while-clone_newipc.patch ipcns-extract-create_ipc_ns.patch nsproxy-extract-create_nsproxy.patch ipcns-3-4-make-free_ipc_ns-static.patch ipcns-move-free_ipcs-proto.patch edac-add-cpc925-memory-controller-driver.patch edac-add-cpc925-memory-controller-driver-cleanup.patch edac-add-cpc925-memory-controller-driver-mc-check-fixup.patch edac-add-edac_device_alloc_index.patch edac-add-edac_device_alloc_index-cleanup.patch edac-cpc925-mc-platform-device-setup.patch edac-cpc925-mc-platform-device-setup-v3.patch edac-add-missing-__devexit_p.patch edac-kconfig-fix-the-meaning-of-edac-abbreviation.patch edac-kconfig-fix-the-meaning-of-edac-abbreviation-fix.patch kernel-constructor-support.patch seq_file-add-function-to-write-binary-data.patch gcov-add-gcov-profiling-infrastructure.patch gcov-add-gcov-profiling-infrastructure-update.patch gcov-enable-gcov_profile_all-for-x86_64.patch dma-mapping-mark-dma_nbits_mask-as-deprecated.patch dma-mapping-mark-dma_sync_single-and-dma_sync_sg-as-deprecated.patch dma-mapping-add-asm-generic-dma-mapping-commonh.patch dma-mapping-x86-use-asm-generic-dma-mapping-commonh.patch dma-mapping-ia64-use-asm-generic-dma-mapping-commonh.patch dma-mapping-ia64-add-config_dma_api_debug-support.patch dma-mapping-dma-debug-fix-compiler-warnings-on-ia64.patch w1-gpio-add-external-pull-up-enable-callback.patch kexec-sysrq-simplify-sysrq-c-handler.patch gru-bug-fixes-for-gru-exception-handling.patch gru-dump-chiplet-state.patch gru-dump-chiplet-state-update.patch gru-dynamic-allocation-of-kernel-contexts.patch gru-dynamic-allocation-of-kernel-contexts-update.patch gru-change-context-load-and-unload.patch gru-support-cch_allocate-for-kernel-threads.patch gru-change-resource-assignment-for-kernel-threads.patch gru-support-contexts-with-zero-dsrs-or-cbrs.patch gru-fix-handling-of-mesq-failures.patch gru-check-context-state-on-reload.patch gru-support-instruction-completion-interrupts.patch gru-support-for-asynchronous-gru-instructions.patch gru-support-for-asynchronous-gru-instructions-fix.patch gru-update-gru-kernel-self-tests.patch gru-update-gru-kernel-self-tests-fix.patch gru-update-to-rev-09-of-gru-spec.patch cramfs-move-cramfs-magic-out-of-cramfs_fsh.patch linuxpps-core-support.patch vfs-take-2add-set_page_dirty_notag.patch reiser4-vfs-add-super_operationssync_inodes-2.patch reiser4-export-remove_from_page_cache.patch reiser4-export-remove_from_page_cache-fix.patch reiser4-export-find_get_pages.patch reiser4.patch reiser4-adjust-to-the-new-aops.patch reiser4-adjust-to-the-new-aops-fixup.patch reiser4-remove-simple_prepare_write-usage.patch reiser4-remove-simple_prepare_write-usage-checkpatch-fixes.patch fs-symlink-write_begin-allocation-context-fix-reiser4-fix.patch reiser4-handling-error-returned-by-d_obtain_alias-fixup.patch reiser4-update-names-of-quota-methods.patch reiser4-use-set_page_dirty_notag.patch make-sure-nobodys-leaking-resources.patch journal_add_journal_head-debug.patch releasing-resources-with-children.patch make-frame_pointer-default=y.patch mutex-subsystem-synchro-test-module.patch slab-leaks3-default-y.patch put_bh-debug.patch add-debugging-aid-for-memory-initialisation-problems.patch shrink_slab-handle-bad-shrinkers.patch keep-track-of-network-interface-renaming.patch workaround-for-a-pci-restoring-bug.patch prio_tree-debugging-patch.patch single_open-seq_release-leak-diagnostics.patch add-a-refcount-check-in-dput.patch getblk-handle-2tb-devices.patch getblk-handle-2tb-devices-fix.patch undeprecate-pci_find_device.patch notify_change-callers-must-hold-i_mutex.patch ^ permalink raw reply [flat|nested] 5+ messages in thread
* sysfs_create_link_nowarn still remains (Was Re: mmotm 2009-06-03-16-33 uploaded 2009-06-03 23:33 mmotm 2009-06-03-16-33 uploaded akpm @ 2009-06-04 3:38 ` KAMEZAWA Hiroyuki 2009-06-04 3:40 ` Greg KH ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: KAMEZAWA Hiroyuki @ 2009-06-04 3:38 UTC (permalink / raw) To: linux-kernel Cc: akpm, garyhade, pbadari, y-goto@jp.fujitsu.com, ebiederm, gregkh On Wed, 03 Jun 2009 16:33:52 -0700 akpm@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2009-06-03-16-33 has been uploaded to > > http://userweb.kernel.org/~akpm/mmotm/ > > and will soon be available at > > git://git.zen-sources.org/zen/mmotm.git > It seems sysfs_create_link_nowarn() is removed in linux-next.patch but driver/base/node.c still includes it. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c04fc586c1a480ba198f03ae7b6cbd7b57380b91 How should we fix it ? Folllowing is a quick hack for compile but ... should be clarified by memory hotplug guys. == sysfs_create_link_nowarn() is obsolete. Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- Index: mmotm-2.6.30-Jun3/drivers/base/node.c =================================================================== --- mmotm-2.6.30-Jun3.orig/drivers/base/node.c +++ mmotm-2.6.30-Jun3/drivers/base/node.c @@ -279,7 +279,7 @@ int register_mem_sect_under_node(struct continue; if (page_nid != nid) continue; - return sysfs_create_link_nowarn(&node_devices[nid].sysdev.kobj, + return sysfs_create_link(&node_devices[nid].sysdev.kobj, &mem_blk->sysdev.kobj, kobject_name(&mem_blk->sysdev.kobj)); } ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: sysfs_create_link_nowarn still remains (Was Re: mmotm 2009-06-03-16-33 uploaded 2009-06-04 3:38 ` sysfs_create_link_nowarn still remains (Was " KAMEZAWA Hiroyuki @ 2009-06-04 3:40 ` Greg KH 2009-06-04 3:49 ` Eric W. Biederman 2009-06-04 15:15 ` Gary Hade 2 siblings, 0 replies; 5+ messages in thread From: Greg KH @ 2009-06-04 3:40 UTC (permalink / raw) To: KAMEZAWA Hiroyuki Cc: linux-kernel, akpm, garyhade, pbadari, y-goto@jp.fujitsu.com, ebiederm On Thu, Jun 04, 2009 at 12:38:13PM +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 03 Jun 2009 16:33:52 -0700 > akpm@linux-foundation.org wrote: > > > The mm-of-the-moment snapshot 2009-06-03-16-33 has been uploaded to > > > > http://userweb.kernel.org/~akpm/mmotm/ > > > > and will soon be available at > > > > git://git.zen-sources.org/zen/mmotm.git > > > It seems sysfs_create_link_nowarn() is removed in linux-next.patch but > driver/base/node.c still includes it. > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c04fc586c1a480ba198f03ae7b6cbd7b57380b91 > > How should we fix it ? Folllowing is a quick hack for compile but ... > should be clarified by memory hotplug guys. I already dropped the removal patch, a few hours ago, look in the linux-next and lkml archives :) thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: sysfs_create_link_nowarn still remains (Was Re: mmotm 2009-06-03-16-33 uploaded 2009-06-04 3:38 ` sysfs_create_link_nowarn still remains (Was " KAMEZAWA Hiroyuki 2009-06-04 3:40 ` Greg KH @ 2009-06-04 3:49 ` Eric W. Biederman 2009-06-04 15:15 ` Gary Hade 2 siblings, 0 replies; 5+ messages in thread From: Eric W. Biederman @ 2009-06-04 3:49 UTC (permalink / raw) To: KAMEZAWA Hiroyuki Cc: linux-kernel, akpm, garyhade, pbadari, y-goto@jp.fujitsu.com, gregkh KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes: 2> On Wed, 03 Jun 2009 16:33:52 -0700 > akpm@linux-foundation.org wrote: > >> The mm-of-the-moment snapshot 2009-06-03-16-33 has been uploaded to >> >> http://userweb.kernel.org/~akpm/mmotm/ >> >> and will soon be available at >> >> git://git.zen-sources.org/zen/mmotm.git >> > It seems sysfs_create_link_nowarn() is removed in linux-next.patch but > driver/base/node.c still includes it. > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c04fc586c1a480ba198f03ae7b6cbd7b57380b91 > > How should we fix it ? Folllowing is a quick hack for compile but ... > should be clarified by memory hotplug guys. Greg has already dropped the patches so the should not appear it the next linux-next. I think your patch is what we want I haven't had a chance to wrap my head around all of that yet. Eric > == > > sysfs_create_link_nowarn() is obsolete. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > Index: mmotm-2.6.30-Jun3/drivers/base/node.c > =================================================================== > --- mmotm-2.6.30-Jun3.orig/drivers/base/node.c > +++ mmotm-2.6.30-Jun3/drivers/base/node.c > @@ -279,7 +279,7 @@ int register_mem_sect_under_node(struct > continue; > if (page_nid != nid) > continue; > - return sysfs_create_link_nowarn(&node_devices[nid].sysdev.kobj, > + return sysfs_create_link(&node_devices[nid].sysdev.kobj, > &mem_blk->sysdev.kobj, > kobject_name(&mem_blk->sysdev.kobj)); > } ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: sysfs_create_link_nowarn still remains (Was Re: mmotm 2009-06-03-16-33 uploaded 2009-06-04 3:38 ` sysfs_create_link_nowarn still remains (Was " KAMEZAWA Hiroyuki 2009-06-04 3:40 ` Greg KH 2009-06-04 3:49 ` Eric W. Biederman @ 2009-06-04 15:15 ` Gary Hade 2 siblings, 0 replies; 5+ messages in thread From: Gary Hade @ 2009-06-04 15:15 UTC (permalink / raw) To: KAMEZAWA Hiroyuki Cc: linux-kernel, akpm, garyhade, pbadari, y-goto@jp.fujitsu.com, ebiederm, gregkh On Thu, Jun 04, 2009 at 12:38:13PM +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 03 Jun 2009 16:33:52 -0700 > akpm@linux-foundation.org wrote: > > > The mm-of-the-moment snapshot 2009-06-03-16-33 has been uploaded to > > > > http://userweb.kernel.org/~akpm/mmotm/ > > > > and will soon be available at > > > > git://git.zen-sources.org/zen/mmotm.git > > > It seems sysfs_create_link_nowarn() is removed in linux-next.patch but > driver/base/node.c still includes it. > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c04fc586c1a480ba198f03ae7b6cbd7b57380b91 > > How should we fix it ? Folllowing is a quick hack for compile but ... > should be clarified by memory hotplug guys. > > == > > sysfs_create_link_nowarn() is obsolete. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > Index: mmotm-2.6.30-Jun3/drivers/base/node.c > =================================================================== > --- mmotm-2.6.30-Jun3.orig/drivers/base/node.c > +++ mmotm-2.6.30-Jun3/drivers/base/node.c > @@ -279,7 +279,7 @@ int register_mem_sect_under_node(struct > continue; > if (page_nid != nid) > continue; > - return sysfs_create_link_nowarn(&node_devices[nid].sysdev.kobj, > + return sysfs_create_link(&node_devices[nid].sysdev.kobj, > &mem_blk->sysdev.kobj, > kobject_name(&mem_blk->sysdev.kobj)); > } > Eric asked me about this yesterday and I told him that I thought this change should be OK. Below is the long-winded version. Gary -- Gary Hade System x Enablement IBM Linux Technology Center 503-578-4503 IBM T/L: 775-4503 garyhade@us.ibm.com http://www.ibm.com/linux/ltc I believe I used it in an earlier version of my changes where register_mem_sect_under_node() was called during boot for the same memory section during both 1. Node registration: topology_init() -> register_one_node() -> link_mem_sections() -> register_mem_sect_under_node() and 2. Memory registration: memory_dev_init() -> add_memory_block() -> register_mem_sect_under_node() I believe I remember looking for a call that I could use in register_mem_sect_under_node() to test for the presence of an existing symlink, could not find one, and ended up using sysfs_create_link_nowarn() to avoid the warnings. register_mem_sect_under_node() was also called during memory hotadd: __add_section() -> register_new_memory() -> add_memory_block() -> register_mem_sect_under_node() but in this case an existing symlink should not already exist. While working on a later version of the changes I think I decided that even though the code worked fine, it was "tacky" to be calling register_mem_sect_under_node() for the same memory section during both node and memory registration. I believe this is why I added a bunch of code to pass the context (BOOT or HOTPLUG) down to add_memory_block() so that I could limit the register_mem_sect_under_node() call to memory hotadd only. >From add_memory_block(): ... if (context == HOTPLUG) ret = register_mem_sect_under_node(mem, nid); ... While doing this I believe I left the sysfs_create_link_nowarn() call as-is because of that paranoia factor. So, unless I'm missing something else I *think* it is OK to change sysfs_create_link_nowarn() to sysfs_create_link() but I'm never 100% certain about these sort of changes without testing. I hope you plan to do that. That said, even though I agree with limiting the use of sysfs_create_link_nowarn() I'm not sure that I agree with totally killing it without replacing it with a clean way to check for the presence of an existing symlink. It seems like, although sometimes "tacky", there might be cases where either "not warning" or "testing for and not creating" makes totally good sense. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-06-04 15:15 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-06-03 23:33 mmotm 2009-06-03-16-33 uploaded akpm 2009-06-04 3:38 ` sysfs_create_link_nowarn still remains (Was " KAMEZAWA Hiroyuki 2009-06-04 3:40 ` Greg KH 2009-06-04 3:49 ` Eric W. Biederman 2009-06-04 15:15 ` Gary Hade
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox