public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Yunpeng Gao <yunpeng.gao@intel.com>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: linux-next: Tree for June 3 (staging)
Date: Thu, 4 Jun 2009 10:52:19 -0700	[thread overview]
Message-ID: <20090604175219.GA18605@kroah.com> (raw)
In-Reply-To: <20090604232610.GA16053@intel.com>

On Fri, Jun 05, 2009 at 07:26:10AM +0800, Yunpeng Gao wrote:
>    I have fixed these compiling bugs in file ffsport.c.
> 
>    But just found that my email client (Outlook) will replace
>    TAB with blanks automatically. So, unfortunately, all the
>    TABs in my first submission patch have been changed to
>    blanks by the Outlook.
>    
>    So I'd like to use the Mutt email client and re-submit
>    the patch as below (the bug-fix of ffsport.c has been included).
>    Does it make sense?
> 

Are you sure you included the fixed up patch?

With the patch you submitted below, I get the following build errors:

drivers/staging/mrst_nand/ffsport.c: In function ‘do_transfer’:
drivers/staging/mrst_nand/ffsport.c:360: error: implicit declaration of function ‘blk_rq_pos’
drivers/staging/mrst_nand/ffsport.c:376: error: implicit declaration of function ‘blk_rq_cur_sectors’
drivers/staging/mrst_nand/ffsport.c: In function ‘spectra_trans_thread’:
drivers/staging/mrst_nand/ffsport.c:499: error: implicit declaration of function ‘blk_fetch_request’
drivers/staging/mrst_nand/ffsport.c:499: warning: assignment makes pointer from integer without a cast
drivers/staging/mrst_nand/ffsport.c:515: error: implicit declaration of function ‘__blk_end_request_cur’
drivers/staging/mrst_nand/ffsport.c:520: error: implicit declaration of function ‘__blk_end_request_all’
drivers/staging/mrst_nand/ffsport.c: In function ‘SBD_setup_device’:
drivers/staging/mrst_nand/ffsport.c:741: error: implicit declaration of function ‘blk_queue_logical_block_size’
make[3]: *** [drivers/staging/mrst_nand/ffsport.o] Error 1
make[3]: *** Waiting for unfinished jobs....


I'll just drop this patch for now, can you resend it to me when it is
fixed up properly?

thanks,

greg k-h

  parent reply	other threads:[~2009-06-04 17:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03  9:09 linux-next: Tree for June 3 Stephen Rothwell
2009-06-03 15:22 ` linux-next: Tree for June 3 (rfkill) Randy Dunlap
2009-06-03 15:29   ` Johannes Berg
2009-06-03 15:47     ` Gábor Stefanik
2009-06-03 15:53       ` Johannes Berg
2009-06-03 16:27   ` Johannes Berg
2009-06-03 17:20   ` Randy Dunlap
2009-06-03 17:33     ` Johannes Berg
2009-06-03 22:48       ` Inaky Perez-Gonzalez
2009-06-03 15:24 ` linux-next: Tree for June 3 (staging) Randy Dunlap
2009-06-03 15:25   ` Greg KH
2009-06-03 15:40     ` Randy Dunlap
2009-06-03 23:11       ` Greg KH
2009-06-04  2:04         ` Gao, Yunpeng
2009-06-04 23:26         ` Yunpeng Gao
2009-06-04 16:00           ` Greg KH
2009-06-04 17:52           ` Greg KH [this message]
2009-06-05  3:31             ` Gao, Yunpeng
2009-06-05 18:58               ` Bartlomiej Zolnierkiewicz
2009-06-05 19:22                 ` Greg KH
2009-06-06 16:30                   ` Yunpeng Gao
2009-06-06  8:37                 ` Gao, Yunpeng
2009-06-04 22:07           ` mISDN: WARNING: at kernel/softirq.c:124 local_bh_enable+0x8f/0xb0() Mathias Kretschmer
2009-06-05  2:59             ` Andrew Morton
2009-06-05 10:01               ` Karsten Keil
2009-06-09 13:05                 ` Karsten Keil
2009-06-22 22:37                   ` Mathias Kretschmer
2009-06-05 18:45           ` linux-next: Tree for June 3 (staging) Bartlomiej Zolnierkiewicz
2009-06-05 20:15             ` Alan Cox
2009-06-06  8:35               ` Gao, Yunpeng
2009-06-03 15:44 ` linux-next: Tree for June 3 (staging++) Randy Dunlap
2009-06-03 15:50 ` linux-next: Tree for June 3 (driver core) Randy Dunlap
2009-06-03 21:22   ` Greg KH
2009-06-03 21:44     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090604175219.GA18605@kroah.com \
    --to=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yunpeng.gao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox