Re: [PATCH] Re: 'make headers_check' failed to install headers to arbitrary location

[Sergei Poselenov <sposelenov@emcraft.com>]

Hello all,

On Thu, 21 May 2009 17:46:59 +0400
Sergei Poselenov <sposelenov@emcraft.com> wrote:

> Hello all,
> 
> A time ago I noted a 'make headers_check' failure, see the
> original message here:
> http://lkml.org/lkml/2009/5/14/248
> 
> The proposed patch fixes this error, please review.
> Tested on 2.6.30-rc5.
> 

Here is another version of the patch which fixes
the "Argument list too long" error for "make headers_check", used xargs
to minimize the perl calls (thanks, Wolfgang).

Signed-off-by: Sergei Poselenov <sposelenov@emcraft.com>
---
 scripts/Makefile.headersinst |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
index 095cfc8..4c54d22 100644
--- a/scripts/Makefile.headersinst
+++ b/scripts/Makefile.headersinst
@@ -54,8 +54,14 @@ quiet_cmd_remove = REMOVE  $(unwanted)
       cmd_remove = rm -f $(unwanted-file)
 
 quiet_cmd_check = CHECK   $(printdir) ($(words $(all-files)) files)
-      cmd_check = $(PERL) $< $(INSTALL_HDR_PATH)/include $(SRCARCH) \
-                  $(addprefix $(install)/, $(all-files));           \
+# Headers list can be pretty long, xargs helps to avoid
+# the "Argument list too long" error.
+      cmd_check = rm -f hdrlist; touch hdrlist;                      \
+                  for f in $(all-files); do                          \
+                  echo "$(install)/$${f} " >> hdrlist; done;         \
+                  cat hdrlist | xargs                                \
+                  $(PERL) $< $(INSTALL_HDR_PATH)/include $(SRCARCH); \
+                  rm -f hdrlist;                                     \
 	          touch $@
 
 PHONY += __headersinst __headerscheck
-- 
1.6.0.6