public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>, linux-kernel@vger.kernel.org
Subject: Re: smatch 1.53 released
Date: Thu, 4 Jun 2009 22:10:29 +0200	[thread overview]
Message-ID: <20090604201029.GG1065@one.firstfloor.org> (raw)
In-Reply-To: <a63d67fe0906041250v6e4252c2g594322a3a49e7307@mail.gmail.com>

Thanks for the description.

> So basically you grep for locking functions and you set the state
> based on that, then you grep for return statements and check that the

When you say "you" you mean smatch is doing that on its own
or does the user need to do that manually?

> Many of the locking false positives come from places where the unlock
> happens in a seperate function.  It should be relatively straight
> forward to make a list functions to say that if frob_the_module()
> returns -12, or -14 that implies it unlocked a certain lock.  I
> haven't done this yet.

How would one pass  that list of functions to smatch?

I understand correctly that right now it's not inter procedural in its
analysis?

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-06-04 20:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02  8:41 smatch 1.53 released Dan Carpenter
2009-06-02 11:56 ` Andi Kleen
2009-06-04 19:50   ` Dan Carpenter
2009-06-04 20:10     ` Andi Kleen [this message]
2009-06-05 13:52       ` Dan Carpenter
2009-06-09  6:15     ` Christian Kujau
2009-06-16 14:54       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090604201029.GG1065@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=error27@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox