From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbZFDUDT (ORCPT ); Thu, 4 Jun 2009 16:03:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751785AbZFDUDM (ORCPT ); Thu, 4 Jun 2009 16:03:12 -0400 Received: from one.firstfloor.org ([213.235.205.2]:44019 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbZFDUDL (ORCPT ); Thu, 4 Jun 2009 16:03:11 -0400 Date: Thu, 4 Jun 2009 22:10:29 +0200 From: Andi Kleen To: Dan Carpenter Cc: Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: smatch 1.53 released Message-ID: <20090604201029.GG1065@one.firstfloor.org> References: <87iqjedf2a.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the description. > So basically you grep for locking functions and you set the state > based on that, then you grep for return statements and check that the When you say "you" you mean smatch is doing that on its own or does the user need to do that manually? > Many of the locking false positives come from places where the unlock > happens in a seperate function. It should be relatively straight > forward to make a list functions to say that if frob_the_module() > returns -12, or -14 that implies it unlocked a certain lock. I > haven't done this yet. How would one pass that list of functions to smatch? I understand correctly that right now it's not inter procedural in its analysis? -Andi -- ak@linux.intel.com -- Speaking for myself only.