From: Sam Ravnborg <sam@ravnborg.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 1/6] headers_check fix: arm, hwcap.h
Date: Thu, 4 Jun 2009 22:16:49 +0200 [thread overview]
Message-ID: <20090604201649.GC13892@uranus.ravnborg.org> (raw)
In-Reply-To: <20090604125306.GC24491@flint.arm.linux.org.uk>
On Thu, Jun 04, 2009 at 01:53:07PM +0100, Russell King wrote:
> On Thu, Jun 04, 2009 at 05:57:56PM +0530, Jaswinder Singh Rajput wrote:
> > fix the following 'make headers_check' warning:
>
> I think headers_check needs fixing - there's nothing wrong with the
> code as it presently stands except the tools obviously can't properly
> parse C preprocessor statements.
You are correct that headers_ceck is limited here and this patch
take some valid code and refactor it to make it headers_check compatible.
But the resulting code is as readable as before and
we keep the noise down when checking our exported headers.
Considering the effort needed to fix the tool I would request
you to take the patch anyway.
Sam
next prev parent reply other threads:[~2009-06-04 20:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 12:23 [PATCH 0/6] headers_check fix patches 20090604 Jaswinder Singh Rajput
2009-06-04 12:27 ` [PATCH 1/6] headers_check fix: arm, hwcap.h Jaswinder Singh Rajput
2009-06-04 12:29 ` [PATCH 2/6] headers_check fix: ia64, fpswa.h Jaswinder Singh Rajput
2009-06-04 12:31 ` [PATCH 3/6] headers_check fix: m68k, swab.h Jaswinder Singh Rajput
2009-06-04 12:35 ` [PATCH 4/6] headers_check fix: mips, ioctl.h Jaswinder Singh Rajput
2009-06-04 12:37 ` [PATCH 5/6] headers_check fix: mn10300, ptrace.h Jaswinder Singh Rajput
2009-06-04 12:38 ` [PATCH 6/6] headers_check fix: mn10300, setup.h Jaswinder Singh Rajput
2009-06-04 12:46 ` [PATCH 4/6] headers_check fix: mips, ioctl.h Ralf Baechle
2009-06-04 20:09 ` Sam Ravnborg
2009-06-05 9:34 ` Arnd Bergmann
2009-06-05 12:04 ` Ralf Baechle
2009-06-04 20:22 ` [PATCH 2/6] headers_check fix: ia64, fpswa.h Sam Ravnborg
2009-06-08 16:33 ` Luck, Tony
2009-06-08 17:48 ` [PATCH] ia64: unexport fpswa.h Sam Ravnborg
2009-06-05 9:26 ` [PATCH 2/6] headers_check fix: ia64, fpswa.h Arnd Bergmann
2009-06-04 12:53 ` [PATCH 1/6] headers_check fix: arm, hwcap.h Russell King
2009-06-04 15:45 ` Jaswinder Singh Rajput
2009-06-04 20:16 ` Sam Ravnborg [this message]
2009-06-05 20:10 ` Russell King
2009-06-05 20:17 ` Robert P. J. Day
2009-06-05 20:48 ` Russell King
2009-06-05 21:24 ` Sam Ravnborg
2009-06-06 8:50 ` Jaswinder Singh Rajput
2009-06-06 9:12 ` Russell King
2009-06-06 9:34 ` Jaswinder Singh Rajput
2009-06-04 20:12 ` [PATCH 0/6] headers_check fix patches 20090604 Sam Ravnborg
2009-06-05 2:00 ` Jaswinder Singh Rajput
2009-06-06 8:10 ` Jaswinder Singh Rajput
2009-06-06 8:43 ` Sam Ravnborg
2009-06-06 9:09 ` Jaswinder Singh Rajput
2009-06-06 12:54 ` [GIT PULL] headers_check fixes Jaswinder Singh Rajput
2009-06-06 13:02 ` Russell King
2009-06-06 13:34 ` Jaswinder Singh Rajput
2009-06-06 13:41 ` Russell King
2009-06-06 14:39 ` Jaswinder Singh Rajput
2009-06-06 21:47 ` Russell King
2009-06-06 21:51 ` Russell King
2009-06-06 22:12 ` Sam Ravnborg
2009-06-06 23:24 ` Russell King
2009-06-07 7:09 ` Sam Ravnborg
2009-06-07 7:16 ` Sam Ravnborg
2009-06-07 10:15 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090604201649.GC13892@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=jaswinder@kernel.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox