From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755250AbZFEJeU (ORCPT ); Fri, 5 Jun 2009 05:34:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751809AbZFEJeM (ORCPT ); Fri, 5 Jun 2009 05:34:12 -0400 Received: from moutng.kundenserver.de ([212.227.126.171]:51882 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751557AbZFEJeL (ORCPT ); Fri, 5 Jun 2009 05:34:11 -0400 From: Arnd Bergmann To: Sam Ravnborg Subject: Re: [PATCH 4/6] headers_check fix: mips, ioctl.h Date: Fri, 5 Jun 2009 10:34:00 +0100 User-Agent: KMail/1.11.90 (Linux/2.6.30-5-generic; KDE/4.2.85; x86_64; ; ) Cc: Ralf Baechle , Jaswinder Singh Rajput , Ingo Molnar , Andrew Morton , LKML , "linux-mips" , Michael Abbott References: <1244118232.5172.26.camel@ht.satnam> <20090604124631.GB19459@linux-mips.org> <20090604200953.GA13892@uranus.ravnborg.org> In-Reply-To: <20090604200953.GA13892@uranus.ravnborg.org> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]> =?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200906051034.01817.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX1+NEhiUibnRTOiVbr40IKiyUfDaHvF+LpX6Y5V wqz9RmQbrj0OJg1o/ZY5E4rwW/niw7cJBl6oU0XKVmZgHvaJvU F5zMSj2VCacTiGKYHBAQQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 04 June 2009, Sam Ravnborg wrote: > Any specific reason why mips does not use include/asm-generic/ioctl.h? > Had mips done so this would not have been an issue. The original include/asm-generic/ioctl.h did not allow overriding the values of _IOC_{SIZEBITS,DIRBITS,NONE,READ,WRITE}, so it was initially not possible to use it. Nowadays, you can simply use the same approach as powerpc: #ifndef _ASM_MIPS_IOCTL_H #define _ASM_MIPS_IOCTL_H #define _IOC_SIZEBITS 13 #define _IOC_DIRBITS 3 #define _IOC_NONE 1U #define _IOC_READ 2U #define _IOC_WRITE 4U /* * The following are included for compatibility */ #define _IOC_VOID 0x20000000 #define _IOC_OUT 0x40000000 #define _IOC_IN 0x80000000 #define _IOC_INOUT (IOC_IN|IOC_OUT) #include #endif /* _ASM_MIPS_IOCTL_H */ This would indeed be a cleaner fix. Arnd <><