From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: lkml@morethan.org, linux-kernel@vger.kernel.org
Subject: Re: [Compile Warning] 2.6.30-rc8 build
Date: Fri, 5 Jun 2009 15:13:46 -0700 [thread overview]
Message-ID: <20090605151346.8fcdd62e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090605230641.2b3013c4@lxorguk.ukuu.org.uk>
On Fri, 5 Jun 2009 23:06:41 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > I don't think there's any way in which gcc can deduce that h->first is
> > non-zero on entry to that loop. Even if it inlines
> > serial_unlink_irq_chain() into serial8250_shutdown().
>
> Why does it care ?
>
> Suppose the list is empty, n is loaded with NULL
>
> That follows the BUG_ON path which expands to include a function marked
> as not returning
Ah, OK.
btw, I think there are still several architectures whose BUG() isn't
correctly set up to tell gcc that it doesn't return. Not that this is
a reason to change the serial code.
next prev parent reply other threads:[~2009-06-05 22:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 16:43 [Compile Warning] 2.6.30-rc8 build Michael S. Zick
2009-06-05 17:22 ` Roland Dreier
2009-06-05 17:40 ` Michael S. Zick
2009-06-05 17:50 ` Roland Dreier
2009-06-05 18:06 ` Alan Cox
2009-06-05 18:01 ` Alan Cox
2009-06-05 21:57 ` Andrew Morton
2009-06-05 22:06 ` Alan Cox
2009-06-05 22:13 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-05 16:50 Michael S. Zick
2009-06-05 17:28 ` Roland Dreier
2009-06-05 17:49 ` Michael S. Zick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605151346.8fcdd62e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@morethan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox