From: Florian Fainelli <florian@openwrt.org>
To: matthieu castet <castet.matthieu@free.fr>
Cc: wim@iguana.be, Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org,
Aleksandar Radovanovic <biblbroks@sezampro.rs>
Subject: Re: add bcm47xx watchdog driver
Date: Fri, 5 Jun 2009 15:58:01 +0200 [thread overview]
Message-ID: <200906051558.02303.florian@openwrt.org> (raw)
In-Reply-To: <4A282D98.6020004@free.fr>
Salut Matthieu,
Le Thursday 04 June 2009 22:24:56 matthieu castet, vous avez écrit :
> This add watchdog driver for broadcom 47xx device.
> It uses the ssb subsytem to access embeded watchdog device.
>
> Because the watchdog timeout is very short (about 2s), a soft timer is used
> to increase the watchdog period.
>
> Note : A patch for exporting the ssb_watchdog_timer_set will
> be submitted on next linux-mips merge. Without this patch it can't
> be build as a module.
Your driver looks good, could you turn this into a platform device/driver
instead ? You declare bcm47xx_wdt_platform_device which is unused and you
also declare a MODULE_ALIAS which suggets it is one.
You are also missing your name in both the header the the MODULE_AUTHOR macro.
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
next prev parent reply other threads:[~2009-06-05 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 20:24 add bcm47xx watchdog driver matthieu castet
2009-06-05 13:58 ` Florian Fainelli [this message]
2009-06-05 14:58 ` castet.matthieu
2009-06-06 10:58 ` Florian Fainelli
2009-06-05 16:57 ` add bcm47xx watchdog driver v2 matthieu castet
2009-06-05 19:48 ` add bcm47xx watchdog driver Andrew Morton
2009-06-05 20:30 ` matthieu castet
2009-06-08 14:15 ` Florian Fainelli
2009-06-10 17:17 ` Wim Van Sebroeck
2009-06-10 18:47 ` matthieu castet
2009-06-10 19:06 ` Wim Van Sebroeck
2009-06-05 19:50 ` Andrew Morton
2009-06-05 20:03 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906051558.02303.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=biblbroks@sezampro.rs \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox