From: Greg KH <greg@kroah.com>
To: Pranith Kumar <pranith.hacks@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Are patches for warnings in drivers/staging/* worth?
Date: Fri, 5 Jun 2009 10:41:32 -0700 [thread overview]
Message-ID: <20090605174132.GC6479@kroah.com> (raw)
In-Reply-To: <4A28B566.1010105@gmail.com>
On Fri, Jun 05, 2009 at 11:34:22AM +0530, Pranith Kumar wrote:
> Hi Greg,
>
> I am looking at the various warnings which occur while compiling the
> staging drivers. Most of them are
>
> * unused variables
> * arg makes pointer from integer without cast
> * un-initialized variable
>
> What in these warnings should I send patches against? Are they worth the
> effort?
Sure they are worth the effort in cleaning up this kind of things.
Always generate patches for the staging tree against the latest
linux-next release.
thanks,
greg k-h
prev parent reply other threads:[~2009-06-05 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 6:04 Are patches for warnings in drivers/staging/* worth? Pranith Kumar
2009-06-05 11:20 ` Stefan Richter
2009-06-05 17:41 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090605174132.GC6479@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pranith.hacks@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox