Re: [PATCH 1/6] headers_check fix: arm, hwcap.h

Russell King
2009-06-06T09:14:15Z

On Sat, Jun 06, 2009 at 02:20:11PM +0530, Jaswinder Singh Rajput wrote:
> On Fri, 2009-06-05 at 21:48 +0100, Russell King wrote:
> > On Thu, Jun 04, 2009 at 10:16:49PM +0200, Sam Ravnborg wrote:
> > > On Thu, Jun 04, 2009 at 01:53:07PM +0100, Russell King wrote:
> > > > On Thu, Jun 04, 2009 at 05:57:56PM +0530, Jaswinder Singh Rajput wrote:
> > > > > fix the following 'make headers_check' warning:
> > > >
> > > > I think headers_check needs fixing - there's nothing wrong with the
> > > > code as it presently stands except the tools obviously can't properly
> > > > parse C preprocessor statements.
> > >
> > > You are correct that headers_ceck is limited here and this patch
> > > take some valid code and refactor it to make it headers_check compatible.
> >
> > Okay, here's the question:
> >
> > Does userspace require anything in the ifdef __ASSEMBLY__ bits?
>
> __ASSEMBLY__ is not specific to kernel. Any one can take benefit of it.
>
>
> > In any case, passing -D__KERNEL__ or -U__KERNEL__ allows unifdef to
> > do the right thing.
> >
> > The problem which unifdef has is that if it finds a symbol in an
> > evaluation that it doesn't know about, it fails the expansion
> > entirely, rather than checking whether the expansion always results
> > in something which should be omitted. In other words:
> >
> > #if defined(__KERNEL__) && (<unknown>)
> >
>
> The problem is why you are trying to complex things which are simple and
> straight.

What you're saying is "you may not follow valid C ways of expressing
conditional compilation" to which I say "go and piss in someone elses
pool".

Since the fix for this in unifdef is soo trivial, and it doesn't require
people to write stuff in ways that stupid idiotic tools can understand,
I'm NEVER going to apply the fix to hwdef.h.

So you now have two options: either supply the (correct) additional
parameter to unifdef, or ignore the stupid idiotic warning message.

> My request to you please think bigger and look at bigger picture.

Same response to you actually. What I'm doing is valid C and there
has NEVER been this convention you're trying to make out.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/