public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] kmemcheck: make bitfield annotations be valid C
Date: Sat, 6 Jun 2009 07:25:14 +0100	[thread overview]
Message-ID: <20090606062514.GA8904@ZenIV.linux.org.uk> (raw)
In-Reply-To: <84144f020905152340v85b72cdr22fe4920bebae510@mail.gmail.com>

On Sat, May 16, 2009 at 09:40:08AM +0300, Pekka Enberg wrote:
> On Fri, May 15, 2009 at 10:55 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
> > From bb8926742d87da95aeb373bc2d4b35a554c5001b Mon Sep 17 00:00:00 2001
> > From: Vegard Nossum <vegard.nossum@gmail.com>
> > Date: Fri, 15 May 2009 21:34:36 +0200
> > Subject: [PATCH] kmemcheck: make bitfield annotations be valid C
> >
> > According to Al Viro, the syntax we were using (putting #ifdef inside
> > macro arguments) was not valid C. He also suggested using begin/end
> > markers instead, which is what we do now.
> >
> > Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> > Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
> 
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> 
> Al, are you okay with this?

Looks sane

  parent reply	other threads:[~2009-06-06  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15 19:55 [PATCH] kmemcheck: make bitfield annotations be valid C Vegard Nossum
2009-05-16  6:40 ` Pekka Enberg
2009-05-16  6:40   ` Pekka Enberg
2009-06-06  6:25   ` Al Viro [this message]
2009-06-07  9:20     ` Ingo Molnar
2009-06-07 12:56       ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090606062514.GA8904@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=penberg@cs.helsinki.fi \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox