Re: [PATCH 18/23] vfs: Teach epoll to use file_hotplug_lock

Davide Libenzi
2009-06-02T16:57:58Z

On Mon, 1 Jun 2009, Eric W. Biederman wrote:

> From: Eric W. Biederman <ebiederm@maxwell.aristanetworks.com>
>
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
> ---
> fs/eventpoll.c | 39 ++++++++++++++++++++++++++++++++-------
> 1 files changed, 32 insertions(+), 7 deletions(-)

This patchset gives me the willies for the amount of changes and possible
impact on many subsystems.
Without having looked at the details, are you aware that epoll does not
act like poll/select, and fds are not automatically removed (as in,
dequeued from the poll wait queue) in any foreseeable amount of time after
a POLLERR is received?
As far as the usespace API goes, they have the right to remain there.

- Davide