From: Greg KH <gregkh@suse.de>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Yunpeng Gao <yunpeng.gao@intel.com>,
linux-kernel@vger.kernel.org,
"devel@linuxdriverproject.org" <devel@driverdev.osuosl.org>
Subject: Re: [PATCH 1/2]Intel Moorestown NAND driver patch for mainline
Date: Sat, 6 Jun 2009 07:57:56 -0700 [thread overview]
Message-ID: <20090606145756.GA29732@suse.de> (raw)
In-Reply-To: <4A2A4EF7.7070509@gmail.com>
On Sat, Jun 06, 2009 at 01:11:51PM +0200, Jiri Slaby wrote:
> On 06/06/2009 06:44 PM, Yunpeng Gao wrote:
> > diff --git a/drivers/staging/mrst_nand/ffsport.c b/drivers/staging/mrst_nand/ffsport.c
> > new file mode 100644
> > index 0000000..5a919f4
> > --- /dev/null
> > +++ b/drivers/staging/mrst_nand/ffsport.c
> > @@ -0,0 +1,953 @@
> > +void glob_udelay(unsigned long usecs)
> > +{
> > + udelay(usecs);
> > +}
> > +
> > +void glob_mdelay(unsigned long msecs)
> > +{
> > + mdelay(msecs);
> > +}
>
> Unneeded wrappers.
<snip>
Thanks for the review, this is one reason why it's in the staging
directory :)
Hopefully someone can send follow-on patches implementing these fixups
(hint...)
greg k-h
next prev parent reply other threads:[~2009-06-06 15:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-06 16:44 [PATCH 1/2]Intel Moorestown NAND driver patch for mainline Yunpeng Gao
2009-06-06 11:11 ` Jiri Slaby
2009-06-06 14:57 ` Greg KH [this message]
2009-06-08 3:34 ` Gao, Yunpeng
2009-06-08 3:08 ` Gao, Yunpeng
2009-06-06 15:04 ` Alan Cox
2009-06-08 4:23 ` Gao, Yunpeng
2009-06-08 10:47 ` David Woodhouse
2009-06-09 0:38 ` Greg KH
2009-06-09 10:48 ` Yunpeng Gao
2009-06-23 10:59 ` Gao, Yunpeng
2009-06-23 11:05 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090606145756.GA29732@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yunpeng.gao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox