From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
Vegard Nossum <vegard.nossum@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmemcheck: make bitfield annotations be valid C
Date: Sun, 7 Jun 2009 13:56:42 +0100 [thread overview]
Message-ID: <20090607125642.GH8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090607092054.GA31286@elte.hu>
On Sun, Jun 07, 2009 at 11:20:54AM +0200, Ingo Molnar wrote:
> > > > According to Al Viro, the syntax we were using (putting #ifdef inside
> > > > macro arguments) was not valid C. He also suggested using begin/end
> > > > markers instead, which is what we do now.
> > > >
> > > > Reported-by: Al Viro <viro@zeniv.linux.org.uk>
> > > > Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
> > >
> > > Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> > >
> > > Al, are you okay with this?
> >
> > Looks sane
>
> Thanks.
>
> This removes the blocker bug from kmemcheck and we can try to push
> it in the .31 merge window. Does the level and amount of bit-field
> annotations look unduly troublesome to you? If we merge kmemcheck
> then we'll have these type annotations forever.
What had been posted in this thread didn't look over the top for me, but
it's really a question for maintainers of the affected code...
prev parent reply other threads:[~2009-06-07 13:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 19:55 [PATCH] kmemcheck: make bitfield annotations be valid C Vegard Nossum
2009-05-16 6:40 ` Pekka Enberg
2009-05-16 6:40 ` Pekka Enberg
2009-06-06 6:25 ` Al Viro
2009-06-07 9:20 ` Ingo Molnar
2009-06-07 12:56 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090607125642.GH8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox