From: Ingo Molnar <mingo@elte.hu>
To: "Figo.zhang" <figo1802@gmail.com>,
Dmitry Adamushko <dmitry.adamushko@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
Tigran Aivazian <tigran@veritas.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]X86:microcode: fix vfree()
Date: Sun, 7 Jun 2009 16:01:13 +0200 [thread overview]
Message-ID: <20090607140113.GI12088@elte.hu> (raw)
In-Reply-To: <1244351929.3355.13.camel@myhost>
* Figo.zhang <figo1802@gmail.com> wrote:
>
> vfree() does it's own 'NULL' check,so no need for check before
> calling it.
looks good, but:
s/it's/its/
s/check,so/check, so/
and:
> static void free_equiv_cpu_table(void)
> {
> - if (equiv_cpu_table) {
> - vfree(equiv_cpu_table);
> - equiv_cpu_table = NULL;
> - }
> + vfree(equiv_cpu_table);
> + equiv_cpu_table = NULL;
> +
> }
stray newline and tab.
Ingo
next prev parent reply other threads:[~2009-06-07 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-07 5:18 [PATCH]X86:microcode: fix vfree() Figo.zhang
2009-06-07 14:01 ` Ingo Molnar [this message]
2009-06-07 14:18 ` [PATCH RESEND]X86:microcode: " Figo.zhang
2009-06-07 14:21 ` Ingo Molnar
2009-06-07 14:25 ` Figo.zhang
2009-06-07 14:28 ` Ingo Molnar
2009-06-07 14:30 ` [PATCH v2]X86:microcode: " Figo.zhang
2009-06-07 14:42 ` [tip:x86/microcode] x86, microcode: Simplify vfree() use tip-bot for Figo.zhang
2009-06-10 14:23 ` [PATCH v2]X86:microcode: fix vfree() Figo.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090607140113.GI12088@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=dmitry.adamushko@gmail.com \
--cc=figo1802@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox