From: Ingo Molnar <mingo@elte.hu>
To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
andreas.herrmann3@amd.com, stable@kernel.org, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86: Detect use of extended APIC ID for AMD CPUs
Date: Sun, 7 Jun 2009 17:33:27 +0200 [thread overview]
Message-ID: <20090607153327.GA8973@elte.hu> (raw)
In-Reply-To: <tip-37f36c1017f0032fa7a1fb85a0cddfc0d526d17f@git.kernel.org>
* tip-bot for Andreas Herrmann <andreas.herrmann3@amd.com> wrote:
> +#ifdef CONFIG_X86_LOCAL_APIC
> + /* check CPU config space for extended APIC ID */
> + if (c->x86 >= 0xf) {
> + unsigned int val;
> +
> + val = read_pci_config(0, 24, 0, 0x68);
> + if ((val & ((1 << 17) | (1 << 18))) == ((1 << 17) | (1 << 18)))
> + set_cpu_cap(c, X86_FEATURE_EXTD_APICID);
> + }
> +#endif
It's possible to enable local APIC but not CONFIG_PCI - in that case
this sequence will fail to build.
Ingo
next prev parent reply other threads:[~2009-06-07 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 10:40 [PATCH] x86: detect use of extended APIC ID for AMD CPUs Andreas Herrmann
2009-06-07 14:42 ` [tip:x86/urgent] x86: Detect " tip-bot for Andreas Herrmann
2009-06-07 15:33 ` Ingo Molnar [this message]
2009-06-08 12:01 ` Andreas Herrmann
2009-06-08 13:12 ` [PATCH v2] x86: detect " Andreas Herrmann
2009-06-08 13:55 ` [PATCH v3] " Andreas Herrmann
2009-06-09 14:52 ` [tip:x86/urgent] x86: Detect " tip-bot for Andreas Herrmann
2009-06-07 18:46 ` Yinghai Lu
2009-06-08 12:18 ` Andreas Herrmann
2009-07-21 10:36 ` [PATCH] x86: detect " Bastian Blank
2009-07-21 16:56 ` Jeremy Fitzhardinge
2009-07-22 9:54 ` Bastian Blank
2009-07-22 14:29 ` Thomas Gleixner
2009-07-22 16:59 ` [PATCH] x86/amd: don't probe for extended APIC ID if APICs are disabled Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090607153327.GA8973@elte.hu \
--to=mingo@elte.hu \
--cc=andreas.herrmann3@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox