From: "Michael S. Zick" <lkml@morethan.org>
To: Harald Welte <HaraldWelte@viatech.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Duane Griffin <duaneg@dghda.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>
Subject: Re: [PATCH 2/2] CPUFREQ: Mark e_powersaver driver as EXPERIMENTAL and DANGEROUS
Date: Mon, 8 Jun 2009 08:06:18 -0500 [thread overview]
Message-ID: <200906080806.21048.lkml@morethan.org> (raw)
In-Reply-To: <20090608102936.GQ4106@prithivi.gnumonks.org>
On Mon June 8 2009, Harald Welte wrote:
> The e_powersaver driver for VIA's C7 CPU's needs to be marked as
> DANGEROUS as it configures the CPU to power states that are out
> of specification.
>
I'll put this and your acpi proposal into a test build today - -
If my machine survives, I'll post the build for others to try.
The current build posted (-09159) does not have *either* control
included, leaving the machine running at silicon "#reset" conditions.
Slow - but safe.
Mike
> According to Centaur, all systems with C7 and Nano CPU's support
> the ACPI p-state method. Thus, the acpi-cpufreq driver should
> be used instead.
>
> Signed-off-by: Harald Welte <HaraldWelte@viatech.com>
> ---
> arch/x86/kernel/cpu/cpufreq/Kconfig | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/cpufreq/Kconfig b/arch/x86/kernel/cpu/cpufreq/Kconfig
> index 52c8398..f138c6c 100644
> --- a/arch/x86/kernel/cpu/cpufreq/Kconfig
> +++ b/arch/x86/kernel/cpu/cpufreq/Kconfig
> @@ -220,11 +220,14 @@ config X86_LONGHAUL
> If in doubt, say N.
>
> config X86_E_POWERSAVER
> - tristate "VIA C7 Enhanced PowerSaver"
> + tristate "VIA C7 Enhanced PowerSaver (DANGEROUS)"
> select CPU_FREQ_TABLE
> - depends on X86_32
> + depends on X86_32 && EXPERIMENTAL
> help
> - This adds the CPUFreq driver for VIA C7 processors.
> + This adds the CPUFreq driver for VIA C7 processors. However, this driver
> + does not have any safeguards to prevent operating the CPU out of spec
> + and is thus considered dangerous. Please use the regular ACPI cpufreq
> + driver, enabled by CONFIG_X86_ACPI_CPUFREQ.
>
> If in doubt, say N.
>
next prev parent reply other threads:[~2009-06-08 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 10:29 [PATCH 2/2] CPUFREQ: Mark e_powersaver driver as EXPERIMENTAL and DANGEROUS Harald Welte
2009-06-08 12:08 ` Matthew Garrett
2009-06-08 13:00 ` Michael S. Zick
2009-06-08 18:13 ` Harald Welte
2009-06-08 18:38 ` Michael S. Zick
2009-06-08 13:06 ` Michael S. Zick [this message]
2009-06-08 13:15 ` Michael S. Zick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906080806.21048.lkml@morethan.org \
--to=lkml@morethan.org \
--cc=HaraldWelte@viatech.com \
--cc=davej@redhat.com \
--cc=duaneg@dghda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox