From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, mjt@tls.msk.ru,
linux-kernel@vger.kernel.org, romieu@fr.zoreil.com
Subject: Re: [patch] r8169: fix crash when large packets are received
Date: Tue, 09 Jun 2009 04:01:14 -0700 (PDT) [thread overview]
Message-ID: <20090609.040114.256650768.davem@davemloft.net> (raw)
In-Reply-To: <4A2D8B8B.80905@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 09 Jun 2009 00:07:07 +0200
> Michael Tokarev reported receiving a large packet could crash
> a machine with RTL8169 NIC.
> ( original thread at http://lkml.org/lkml/2009/6/8/192 )
>
> Problem is this driver tells that NIC frames up to 16383 bytes
> can be received but provides skb to rx ring allocated with
> smaller sizes (1536 bytes in case standard 1500 bytes MTU is used)
>
> When a frame larger than what was allocated by driver is received,
> dma transfert can occurs past the end of buffer and corrupt
> kernel memory.
>
> Fix is to tell to NIC what is the maximum size a frame can be.
>
> This bug is very old, (before git introduction, linux-2.6.10), and
> should be backported to stable versions.
>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Tested-by: Michael Tokarev <mjt@tls.msk.ru>
Applied to net-2.6, thanks Eric.
prev parent reply other threads:[~2009-06-09 11:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 22:07 [patch] r8169: fix crash when large packets are received Eric Dumazet
2009-06-09 1:40 ` Jon Masters
2009-06-09 2:57 ` David Miller
2009-06-09 8:59 ` Michael Tokarev
2009-06-09 10:54 ` David Miller
2009-06-09 11:01 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090609.040114.256650768.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox