Re: [PATCH 18/19] io-controller: Debug hierarchical IO scheduling

Vivek Goyal
2009-06-19T14:06:25Z

On Fri, Jun 19, 2009 at 09:40:38AM +0800, Gui Jianfeng wrote:

[..]
> > + * An entity has been freshly added to active tree. Either it came from
> > + * idle tree or it was not on any of the trees. Do the accounting.
> > + */
> > +static inline void bfq_account_for_entity_addition(struct io_entity *entity)
> > +{
> > + struct io_group *iog = io_entity_to_iog(entity);
> > +
> > + if (iog) {
> > + struct elv_fq_data *efqd;
> > + char path[128];
> > +
> > + /*
> > + * Keep track of how many times a group has been removed
> > + * from active tree because it did not have any active
> > + * backlogged ioq under it
> > + */
>
> Hi Vivek,
>
> Should the comment here be "added to" rather than "removed from"?

Yes, it is copy paste error. Fixed for next posting.

Thanks
Vivek