From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756458AbZFJHub (ORCPT ); Wed, 10 Jun 2009 03:50:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754529AbZFJHuX (ORCPT ); Wed, 10 Jun 2009 03:50:23 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:52345 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbZFJHuW (ORCPT ); Wed, 10 Jun 2009 03:50:22 -0400 Date: Wed, 10 Jun 2009 00:50:18 -0700 From: Andrew Morton To: Martin Zwickel Cc: linux-kernel@vger.kernel.org, Alan Stern , linux-usb@vger.kernel.org Subject: Re: FDTI-SIO: kernel-oops after resume Message-Id: <20090610005018.2c84d229.akpm@linux-foundation.org> In-Reply-To: <20090609063948.GA17564@novabasedigitaltv.de> References: <20090609063948.GA17564@novabasedigitaltv.de> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Jun 2009 08:39:48 +0200 Martin Zwickel wrote: > Hi all, > > I got an oops after resuming from suspend S3 state. > > I had the ttyUSB0 opened with minicom and went to suspend S3. > While in suspend I removed the physical serial device converter. > While resuming I got this kernel oops: > > [output] > BUG: unable to handle kernel NULL pointer dereference at 00000044 > IP: [] del_timer+0xc/0x4c > *pde = 00000000 > Oops: 0000 [#1] PREEMPT SMP > last sysfs file: /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq > Modules linked in: iptable_filter ip_tables x_tables i915 fb drm > i2c_algo_bit cfbcopyarea i2c_core cfbimgblt cfbfillrect ipv6 > snd_hda_codec_conexant snd_hda_intel ftdi_sio iwlagn usbserial iwlcore > snd_hda_codec pcspkr evdev > > Pid: 16129, comm: minicom Not tainted (2.6.29.4 #3) ESPRIMO Mobile V5505 > > EIP: 0060:[] EFLAGS: 00210286 CPU: 0 > EIP is at del_timer+0xc/0x4c > EAX: 00000044 EBX: 00000044 ECX: f2224b00 EDX: 00000044 > ESI: 00000000 EDI: 00000000 EBP: f6489df0 ESP: f6489de4 > DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 > Process minicom (pid: 16129, ti=f6488000 task=f1b54000 task.ti=f6488000) > Stack: > 00000000 f1a31c00 00000034 f6489e38 c01311a3 00000044 00200246 f6489e20 > 00200246 00000000 c0609e00 00000002 00000000 f6489e44 00200246 f6489e30 > c014e2a6 c1aa7f80 f1a31c00 00000400 00000000 f6489e40 c01312c3 f6489e58 > Call Trace: > [] ? __cancel_work_timer+0x20/0x135 > [] ? __pagevec_free+0x17/0x1e > [] ? cancel_delayed_work_sync+0xb/0xd > [] ? ftdi_close+0xc3/0xe2 [ftdi_sio] > [] ? fasync_helper+0xb3/0xbc > [] ? serial_close+0x7b/0x113 [usbserial] > [] ? tty_release_dev+0x15b/0x392 > [] ? __pagevec_free+0x17/0x1e > [] ? add_partial+0x44/0x49 > [] ? mntput_no_expire+0x18/0xe7 > [] ? dput+0x1d/0xfc > [] ? tty_release+0x12/0x1c > [] ? __fput+0xaf/0x155 > [] ? fput+0x17/0x19 > [] ? filp_close+0x51/0x5b > [] ? put_files_struct+0x68/0xaa > [] ? exit_files+0x37/0x3c > [] ? do_exit+0x150/0x62e > [] ? do_group_exit+0x5f/0x88 > [] ? sys_exit_group+0xf/0x13 > [] ? sysenter_do_call+0x12/0x25 > Code: 04 0f 0b eb fe 39 50 08 75 0a 83 38 00 b9 01 00 00 00 75 07 e8 10 fe ff ff 89 c1 5d 89 c8 c3 55 89 e5 56 31 f6 53 89 c3 83 ec 04 <83> 38 00 74 34 8d 55 f4 e8 4c fd ff ff 83 3b 00 89 c1 74 1b 8b > EIP: [] del_timer+0xc/0x4c SS:ESP 0068:f6489de4 > ---[ end trace 679defbdbe4aa1e4 ]--- > [/output] > > Minicom said it lost the device, but was unable to close it. > > The attached device: > [output] > USB Serial support registered for FTDI USB Serial Device > ftdi_sio 6-1:1.0: FTDI USB Serial Device converter detected > usb 6-1: Detected FT8U232AM > usb 6-1: FTDI USB Serial Device converter now attached to ttyUSB0 > usbcore: registered new interface driver ftdi_sio > ftdi_sio: v1.4.3:USB FTDI Serial Converters Driver > [/output] > > > My kernel runs with SMP and HIGHMEM if it matters: > Linux tt-business 2.6.29.4 #3 SMP PREEMPT Fri Jun 5 00:03:39 WEST 2009 i686 Intel(R) Core(TM)2 Duo CPU T7300 @ 2.00GHz GenuineIntel GNU/Linux > The oops is very very similar to the one which Daniel Mack reported, and which was fixed by commit c16199fcd341f10147eb2e29a60aed41ceca55b4 Author: Alan Stern Date: Thu Apr 30 10:06:19 2009 -0400 usb-serial: ftdi_sio: fix reference counting of ftdi_private but your 2.6.29.4 contained that fix, so it seems that we still have a problem here?