From: Andrew Morton <akpm@linux-foundation.org>
To: "Richard Röjfors" <richard.rojfors.ext@mocean-labs.com>
Cc: linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net,
dbrownell@users.sourceforge.net
Subject: Re: [PATCH 2/9] SPI: xilinx_spi: Added platform driver and support for DS570
Date: Wed, 10 Jun 2009 01:57:10 -0700 [thread overview]
Message-ID: <20090610015710.3afb1a92.akpm@linux-foundation.org> (raw)
In-Reply-To: <4A2F737A.2000407@mocean-labs.com>
On Wed, 10 Jun 2009 10:48:58 +0200 Richard R__jfors <richard.rojfors.ext@mocean-labs.com> wrote:
> On 09-06-10 01.09, Andrew Morton wrote:
> > On Fri, 05 Jun 2009 15:40:19 +0200
> > Richard R__jfors <richard.rojfors.ext@mocean-labs.com> wrote:
> >
> >> This patch splits xilinx_spi into three parts, an OF and a platform
> >> driver and generic part.
> >>
> >> The generic part now also works on X86 and also supports the Xilinx
> >> SPI IP DS570
> >
> > Unfortunately we already have two fairly significant
> > drivers/spi/xilinx_spi.c patches queued in -mm:
> > spi-move-more-spi_setup-functionality-into-core.patch and
> > spi-move-common-spi_setup-functionality-into-core.patch. Applying this
> > patch on top of those makes rather a mess.
> >
> > Hopefully things will still be OK if I skip this patch. You didn't
> > identify the dependencies between those nine patchs. Can you please
> > explain that?
>
> Actually all patches except for the 7th(of 9), would work without the
> xilinx_spi-patch.
> The 7th (Timberdale MFD) would not build. Some of the othe drivers are not
> possible to select because they depend on the MFD in their Kconfigs,
> but not the code.
Confused.
See, my problem is that normally I will hold off on sending a patch to
its subsystem maintainer until its prerequisite patch(es) are in mainline.
But for each of these patches, I don't know what the exact prerequisites
are. Help?
(The simple alternative is for me to seek acks and merge them all
myself. But sometimes getting those acks is hard).
> I would be very happy if you applied all but the 7th (MFD) and 2nd (SPI) anyway.
>
> I will update my SPI-patch to work against the two patches you point out above.
> And them I will resend the Timberdale MFD and the Xilinx SPI patch.
>
> Would that be OK?
That would be great, thanks.
next prev parent reply other threads:[~2009-06-10 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 13:40 [PATCH 2/9] SPI: xilinx_spi: Added platform driver and support for DS570 Richard Röjfors
2009-06-09 23:09 ` Andrew Morton
2009-06-10 8:48 ` Richard Röjfors
2009-06-10 8:57 ` Andrew Morton [this message]
2009-06-10 13:37 ` Richard Röjfors
2009-06-11 13:24 ` [PATCH 2/9 v2] " Richard Röjfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090610015710.3afb1a92.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.rojfors.ext@mocean-labs.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox