Re: [PATCH] [11/16] HWPOISON: check and isolate corrupted free pages v2

Nick Piggin
2009-06-09T15:31:26Z

On Tue, Jun 09, 2009 at 10:56:14PM +0800, Wu Fengguang wrote:
> > Moving hot and cold functions together could become an issue
> > indeed. Mostly it probably matters a little less than code
> > within a single function due to their size. But I think gcc
> > already has options to annotate this kind of thing which we
> > could be using.
>
> Can we tell gcc "I bet this _function_ is rarely used"?

Yes you can annotate a function as hot or cold.

> > So it's not such a good argument against moving things out of
> > hotpaths, or guiding in which files to place functions.
>
> Yes.
>
> > Anyway, in this case it is not a "nack" from me. Just that I
> > would like to see the non-fastpath code too or at least if
> > it can be thought about.
>
> I think Andi would be pleased to present you with his buddy page
> isolation code :)