public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Stefan Bader <stefan.bader@canonical.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pierre@ossman.eu, linux-kernel@vger.kernel.org,
	Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] mmc: prevent dangling block device from accessing stale queues
Date: Wed, 10 Jun 2009 23:02:47 +0200	[thread overview]
Message-ID: <20090610210247.GC1381@ucw.cz> (raw)
In-Reply-To: <4A280BD4.9080908@canonical.com>

On Thu 2009-06-04 20:00:52, Stefan Bader wrote:
> Kernel: 2.6.30-rc7 based
> Worked in 2.6.28 (probably only because things went at a different speed)
>
> Testcase: Use ext3/ext4 on a SD card partitioned with one primary DOS 
> partition and leave it mounted while suspend/resume.
>
> Result: After resume the partition table of the SD card has been erased.
>
> The detailed description can be found at:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/383668
>
> In essence the mmc block device frees the generic request queue before 
> the last user of the gendisk has stopped using it leaving an invalid 
> queue pointer which get unfortunately re-used before more requests come 
> in for the old device.
>
> The bugfix will cause more I/O error messages and might not be the 
> ultimate way things should work, but it prevents data from getting lost.

Thanks for finding root cause of this!
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2009-06-10 21:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-04 18:00 [PATCH] mmc: prevent dangling block device from accessing stale queues Stefan Bader
2009-06-04 18:29 ` Pierre Ossman
2009-06-04 19:00   ` Stefan Bader
2009-06-04 19:15     ` Matt Fleming
2009-06-04 19:22       ` Pierre Ossman
2009-06-04 19:23       ` Stefan Bader
2009-06-04 19:21     ` Pierre Ossman
2009-06-04 19:37       ` Stefan Bader
2009-06-10 21:02 ` Pavel Machek [this message]
2009-06-23 15:01   ` Stefan Bader
2009-07-01 11:09     ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090610210247.GC1381@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre@ossman.eu \
    --cc=rjw@sisk.pl \
    --cc=stefan.bader@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox