From: Dave Jones <davej@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
mark.langsdorf@amd.com
Subject: Re: [PATCH 3/6] cpumask: avoid playing with cpus_allowed in powernow-k8.c
Date: Thu, 11 Jun 2009 19:25:17 -0400 [thread overview]
Message-ID: <20090611232517.GA32486@redhat.com> (raw)
In-Reply-To: <20090611225928.E6FF4DDDA1@ozlabs.org>
On Thu, Jun 11, 2009 at 10:59:58PM +0930, Rusty Russell wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
>
> It's generally a very bad idea to mug some process's cpumask: it could
> legitimately and reasonably be changed by root, which could break us
> (if done before our code) or them (if we restore the wrong value).
>
> I did not replace powernowk8_target; it needs fixing, but it grabs a
> mutex (so no smp_call_function_single here) but Mark points out it can
> be called multiple times per second, so work_on_cpu is too heavy.
This one clashes with some diffs I merged earlier in cpufreq.git.
Can you rebase on top of that please?
(The other two were fine).
Otherwise, they all look ok to me. As long as they survive testing I
see no reason not to push them for .31.
Thanks,
Dave
next prev parent reply other threads:[~2009-06-11 23:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 13:29 [PATCH 3/6] cpumask: avoid playing with cpus_allowed in powernow-k8.c Rusty Russell
2009-06-11 23:25 ` Dave Jones [this message]
2009-06-12 11:25 ` [PATCH] " Rusty Russell
2009-06-15 15:40 ` Langsdorf, Mark
2009-06-12 11:26 ` [PATCH 3/6] " Rusty Russell
2009-06-12 11:28 ` [PATCH] cpumask: new cpumask operators for arch/x86/kernel/cpu/cpufreq/powernow-k8.c Rusty Russell
2009-06-15 15:40 ` Langsdorf, Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611232517.GA32486@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@amd.com \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox