From: Dave Jones <davej@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Dominik Brodowski <linux@brodo.de>
Subject: Re: [PATCH 2/6] cpumask: avoid playing with cpus_allowed in speedstep-ich.c
Date: Thu, 11 Jun 2009 19:31:25 -0400 [thread overview]
Message-ID: <20090611233125.GB32486@redhat.com> (raw)
In-Reply-To: <20090611225927.E324ADDD04@ozlabs.org>
On Thu, Jun 11, 2009 at 10:59:58PM +0930, Rusty Russell wrote:
Minor nit (and this was there before your change, but because
you moved it, checkpatch now whines..)
> +static void get_freqs_on_cpu(void *_get_freqs)
> +{
> + struct get_freqs *get_freqs = _get_freqs;
> +
> + get_freqs->ret =
> + speedstep_get_freqs(speedstep_processor,
> + &speedstep_freqs[SPEEDSTEP_LOW].frequency,
> + &speedstep_freqs[SPEEDSTEP_HIGH].frequency,
> + &get_freqs->policy->cpuinfo.transition_latency,
> + &speedstep_set_state);
> +}
line over 80 characters.
I'll just pull it back one tab.
Perhaps some variable renaming in this file is called for to reduce
some of the redundancy in such lines.
Dave
prev parent reply other threads:[~2009-06-11 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 13:29 [PATCH 2/6] cpumask: avoid playing with cpus_allowed in speedstep-ich.c Rusty Russell
2009-06-11 23:31 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611233125.GB32486@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@brodo.de \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox