public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Patrick Ringl <patrick.ringl@gmx.de>
Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org,
	linux-kbuild@vger.kernel.org,
	Roman Zippel <zippel@linux-m68k.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: PATCH: README - Fix misleading pointer to the defconf directory
Date: Fri, 12 Jun 2009 11:50:39 +0200	[thread overview]
Message-ID: <200906121150.40332.arnd@arndb.de> (raw)
In-Reply-To: <4A321A3C.6030400@gmx.de>

On Friday 12 June 2009, Patrick Ringl wrote:
> the README simply points to a wrong/non-existent directory where the default
> configurations are not suited, hence the patch.

On six architectures, it's still the right directory, your patch breaks it.

> Signed-off-by: Patrick Ringl <patrick_@freenet.de>
>
> --- linux.orig/README   2009-06-10 05:05:27.000000000 +0200
> +++ linux/README        2009-06-12 10:46:15.000000000 +0200
> @@ -175,7 +175,7 @@
>                            Like above, but avoids cluttering the screen
>                            with questions already answered.
>         "make defconfig"   Create a ./.config file by using the default
> -                          symbol values from arch/$ARCH/defconfig.
> +                          symbol values from arch/$ARCH/configs/*_defconfig.
>         "make allyesconfig"
>                            Create a ./.config file by setting symbol
>                            values to 'y' as much as possible.

You could write e.g.

	default symbol values from one of arch/{$ARCH}/defconfig or
	arch/${ARCH}/configs/${PLATFORM}_defconfig, depending on
	the architecture.

It would also be consistent to list the specific defconfigs here, like

	"make ${PLATFORM}_defconfig"
			Create a ./.config file by using the default
			symbol values from
			arch/${ARCH}/configs/${PLATFORM}_defconfig.
			Use "make help" to see a list of the available
			platforms on your architecture.

Not also that your patch should be merged through a subsystem maintainer.
If you don't know who that is, use scripts/get_maintainer.pl.
For scripts/kconfig/* and README it suggests sending it to Sam, Roman and
linux-kbuild@vger.kernel.org, which sounds right.

	Arnd <><

  reply	other threads:[~2009-06-12  9:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12  9:05 PATCH: README - Fix misleading pointer to the defconf directory Patrick Ringl
2009-06-12  9:50 ` Arnd Bergmann [this message]
2009-06-12 10:07   ` Patrick Ringl
2009-06-12 11:58 ` PATCH: README - Fix misleading pointer to the defconf directory [NEW] Patrick Ringl
2009-06-14 20:20   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906121150.40332.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrick.ringl@gmx.de \
    --cc=sam@ravnborg.org \
    --cc=torvalds@osdl.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox