From: Ingo Molnar <mingo@elte.hu>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/checksyscalls.sh: only whine perf_counter_open when supported
Date: Fri, 12 Jun 2009 14:05:07 +0200 [thread overview]
Message-ID: <20090612120507.GH16044@elte.hu> (raw)
In-Reply-To: <1244806169-12232-1-git-send-email-vapier@gentoo.org>
* Mike Frysinger <vapier@gentoo.org> wrote:
> If the port does not support HAVE_PERF_COUNTERS, then they can't
> support the perf_counter_open syscall either. Rather than forcing
> everyone to add an ignore (or suffer the warning until they get
> around to implementing support), only whine about the syscall when
> applicable.
No, this patch is wrong - it's really easy to add support: just hook
up the syscall. This should happen for every architecture really, so
the warning is correct and it should not be patched out.
PMU support is not required to get perfcounters support: if an
architecture hooks up the syscall it will get generic software
counters and the tools will work as well.
Profiling falls back to a hrtimer-based sampling method - this is a
much better fallback than oprofile's fall-back to the timer tick.
This hrtimer based sampling is dynticks/nohz-correct and can go
beyond HZ if the architecture supports hrtimers.
Thanks,
Ingo
next prev parent reply other threads:[~2009-06-12 12:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 11:29 [PATCH] scripts/checksyscalls.sh: only whine perf_counter_open when supported Mike Frysinger
2009-06-12 12:05 ` Ingo Molnar [this message]
2009-06-12 12:13 ` Mike Frysinger
2009-06-12 12:17 ` Ingo Molnar
2009-06-12 12:22 ` Mike Frysinger
2009-06-12 12:31 ` Ingo Molnar
2009-06-12 12:41 ` Mike Frysinger
2009-06-12 12:59 ` Ingo Molnar
2009-06-12 13:04 ` Mike Frysinger
2009-06-12 13:09 ` Ingo Molnar
2009-06-12 13:21 ` Mike Frysinger
2009-06-12 13:56 ` Ingo Molnar
2009-06-12 15:25 ` Alan Cox
2009-06-12 15:56 ` Ingo Molnar
2009-06-12 16:57 ` Ingo Molnar
2009-06-12 17:11 ` Mike Frysinger
2009-06-12 13:34 ` Mike Frysinger
2009-06-12 15:16 ` Mike Frysinger
2009-06-12 15:21 ` Ingo Molnar
2009-06-12 15:29 ` Mike Frysinger
2009-06-12 15:50 ` Ingo Molnar
2009-06-13 21:00 ` Ingo Molnar
2009-06-13 4:37 ` Paul Mackerras
2009-06-13 10:48 ` Mike Frysinger
2009-06-14 9:37 ` Paul Mundt
2009-06-14 9:55 ` Mike Frysinger
2009-06-14 10:11 ` Paul Mundt
2009-06-14 10:55 ` Mike Frysinger
2009-06-14 11:20 ` Paul Mundt
2009-06-14 11:47 ` Mike Frysinger
2009-06-14 11:20 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612120507.GH16044@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox