Re: [PATCH] lis3: add click function

[Daniel Mack <daniel@caiaq.de>]

On Fri, Jun 12, 2009 at 02:50:08PM +0200, Éric Piel wrote:
> > static struct spi_board_info my_spi_devices[] __initdata = {
> >         {
> >                 .modalias       = "lis3lv02d_spi",
> >                 .max_speed_hz   = 1000000,
> >                 .bus_num        = 0,
> >                 .chip_select    = 0,
> >                 .controller_data = (void *) mfp_to_gpio(GPIO_ACCEL_CS),
> >                 .platform_data  = &lis3_pdata,
> >                 .irq            = gpio_to_irq(mfp_to_gpio(GPIO_ACCEL_IRQ)),
> >         },
> > 
> I see. So your platform is not among the one contained in the vanilla
> kernel? Shouldn't this above code be written somewhere so that people
> know about it? Some of the values do not seem especially obvious!

The platform is currently under development and will be merged at some
later point. The magics above are just GPIO defintions - everything
else is just the usual glue logic you add when registering an SPI
device.

> > We're using the IRQ outputs of that chips directly as source to other
> > circuity, so there is no userspace logic in the game. If anyone needs
> > that, a simple callback function would be easy to add at some later
> > point.
> I guess that to have the functionality in ACPI, a complete handling of
> the interruptions, up to the generation of button events would be
> needed. This can be done later on, whenever someone finds the need...

Ack.

> Acked-by: Eric Piel <eric.piel@tremplin-utc.net>

Thanks :)

Andrew, could you queue that one?

Daniel