From: Oleg Nesterov <oleg@redhat.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] posix-cpu-timers: avoid do_sys_times() races with __exit_signal()
Date: Fri, 12 Jun 2009 15:46:26 +0200 [thread overview]
Message-ID: <20090612134626.GA3784@redhat.com> (raw)
In-Reply-To: <20090612103403.2e1d576f@dhcp-lab-109.englab.brq.redhat.com>
On 06/12, Stanislaw Gruszka wrote:
>
> Protect thread_group_cputime() call by siglock, to avoid possible (but
> to be honest - very improbable) double times accounting of exiting task.
> This is revert of commit 2b5fe6de58276d0b5a7c884d5dbfc300ca47db78
> "thread_group_cputime: move a couple of callsites outside of ->siglock",
> but implementation of thread_group_cputime() was different then.
Yes, at that time thread_group_cputime() was reading per-cpu data, and
->siglock was unneeded.
I think the patch is correct.
Oleg.
next prev parent reply other threads:[~2009-06-12 13:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 8:34 [PATCH 1/2] posix-cpu-timers: avoid do_sys_times() races with __exit_signal() Stanislaw Gruszka
2009-06-12 13:46 ` Oleg Nesterov [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-15 8:36 Stanislaw Gruszka
2009-06-12 6:49 Stanislaw Gruszka
2009-06-12 7:09 ` Peter Zijlstra
2009-06-12 7:56 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612134626.GA3784@redhat.com \
--to=oleg@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sgruszka@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox