Re: -git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function '__symbol_get'

Michael Chan
2009-06-14T14:51:25Z

James Bottomley wrote:

> On Sat, 2009-06-13 at 19:18 -0700, Michael Chan wrote:
> >
> > This will require some additional infra-structure. We can look into
> > this when we support the 10G driver. Thanks.
>
> So if you're going to redo it for the 10G driver, and without the 10G
> driver there really seems no need to have a call by
> reflection in there,
> why not simply do a direct call until the 10G driver is added? This
> will save everyone potential hassle from what is a highly unusual
> interface.
>

There's an additional usage issue if we switch to a direct call. The
cnic driver will now have a permanent reference on the bnx2 driver
after it is loaded. Networking users will be unable to unload the
bnx2 driver once the cnic driver is loaded.

This may not be a serious issue, but one of the goals of the design is
to have minmal impact on networking users. Since kernel 2.6, users
have been able to unload networking drivers at any time.

Thanks.