-git tree build failure #2: drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’

Ingo Molnar
2009-06-13T06:29:57Z

* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> Ingo Molnar wrote:
> > today's -git fails to build with ipv6 disabled (x86):
> >
> > drivers/built-in.o: In function `cnic_get_v6_route':
> > cnic.c:(.text+0x104c42): undefined reference to `ip6_route_output'
> >
> > introduced by this new driver:
> >
> > a463696: [SCSI] cnic: Add new Broadcom CNIC driver.
>
> I just posted a patch for this to netdev and it was acked by its maintainer.
> Patch is below.

This solves the first build failure but there's still a second build
failure:

drivers/net/cnic.c: In function ‘init_bnx2_cnic’:
drivers/net/cnic.c:2520: error: implicit declaration of function ‘__symbol_get’
drivers/net/cnic.c:2520: warning: assignment makes pointer from integer without a cast
make[1]: *** [drivers/net/cnic.o] Error 1
make: *** [drivers/net/cnic.o] Error 2

This too triggers with the config i sent. The patch below solves it
- but i havent done more testing.

Ingo

Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/drivers/net/cnic.c b/drivers/net/cnic.c
index 8d74037..49135cc 100644
--- a/drivers/net/cnic.c
+++ b/drivers/net/cnic.c
@@ -25,6 +25,8 @@
#include <linux/delay.h>
#include <linux/ethtool.h>
#include <linux/if_vlan.h>
+#include <linux/module.h>
+
#if defined(CONFIG_VLAN_8021Q) || defined(CONFIG_VLAN_8021Q_MODULE)
#define BCM_VLAN 1
#endif