From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760878AbZFLLKj (ORCPT ); Fri, 12 Jun 2009 07:10:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758812AbZFLLKR (ORCPT ); Fri, 12 Jun 2009 07:10:17 -0400 Received: from ozlabs.org ([203.10.76.45]:58227 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759569AbZFLLKP (ORCPT ); Fri, 12 Jun 2009 07:10:15 -0400 From: Rusty Russell To: Stephen Rothwell Subject: Re: linux-next: rr-latest-cpumask/sparc tree build failure Date: Fri, 12 Jun 2009 20:40:10 +0930 User-Agent: KMail/1.11.2 (Linux/2.6.28-11-generic; KDE/4.2.2; i686; ; ) Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org References: <20090612185102.2d1391e5.sfr@canb.auug.org.au> In-Reply-To: <20090612185102.2d1391e5.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906122040.10541.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 12 Jun 2009 06:21:02 pm Stephen Rothwell wrote: > Hi Rusty, > > Today's linux-next build (sparc64 defconfig) failed like this: > > arch/sparc/mm/init_64.c: In function 'paging_init': > arch/sparc/mm/init_64.c:1802: error: 'CPU_MASK_ALL_PTR' undeclared (first OK, Dave could you take/fold Stephen's fix then? FYI here's the patch explaining why we're CPU_MASK_ALL_PTR -> cpu_all_mask: Subject: cpumask: remove dangerous CPU_MASK_ALL_PTR (Thanks to Al Viro for reminding me of this, via Ingo) CPU_MASK_ALL is the (deprecated) "all bits set" cpumask, defined as so: #define CPU_MASK_ALL (cpumask_t) { { ... } } Taking the address of such a temporary is questionable at best, unfortunately 321a8e9d (cpumask: add CPU_MASK_ALL_PTR macro) added CPU_MASK_ALL_PTR: #define CPU_MASK_ALL_PTR (&CPU_MASK_ALL) Which formalizes this practice. One day gcc could bite us over this usage (though we seem to have gotten away with it so far). Now all callers are removed, we kill it. Signed-off-by: Rusty Russell Acked-by: Ingo Molnar Reported-by: Al Viro Cc: Mike Travis --- include/linux/cpumask.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h --- a/include/linux/cpumask.h +++ b/include/linux/cpumask.h @@ -324,8 +324,6 @@ static inline const struct cpumask *get_ [BITS_TO_LONGS(NR_CPUS)-1] = CPU_MASK_LAST_WORD \ } } -#define CPU_MASK_ALL_PTR (&CPU_MASK_ALL) - #else #define CPU_MASK_ALL \ @@ -333,7 +331,6 @@ static inline const struct cpumask *get_ /* cpu_mask_all is in init/main.c */ extern cpumask_t cpu_mask_all; -#define CPU_MASK_ALL_PTR (&cpu_mask_all) #endif