[PATCH] x86: use zalloc_cpumask_var in arch_early_irq_init

[PATCH] x86: use zalloc_cpumask_var in arch_early_irq_init

[Yinghai Lu]

So could make sure MAXSMP get clearred cpumask

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 arch/x86/kernel/apic/io_apic.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6/arch/x86/kernel/apic/io_apic.c
@@ -187,8 +187,8 @@ int __init arch_early_irq_init(void)
 	for (i = 0; i < count; i++) {
 		desc = irq_to_desc(i);
 		desc->chip_data = &cfg[i];
-		alloc_cpumask_var_node(&cfg[i].domain, GFP_NOWAIT, node);
-		alloc_cpumask_var_node(&cfg[i].old_domain, GFP_NOWAIT, node);
+		zalloc_cpumask_var_node(&cfg[i].domain, GFP_NOWAIT, node);
+		zalloc_cpumask_var_node(&cfg[i].old_domain, GFP_NOWAIT, node);
 		if (i < NR_IRQS_LEGACY)
 			cpumask_setall(cfg[i].domain);
 	}

[PATCH] kvm: remove the duplicated cpumask_clear

[Yinghai Lu]

zalloc_cpumask_var already had that clear.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>

---
 virt/kvm/kvm_main.c |    1 -
 1 file changed, 1 deletion(-)

Index: linux-2.6/virt/kvm/kvm_main.c
===================================================================
--- linux-2.6.orig/virt/kvm/kvm_main.c
+++ linux-2.6/virt/kvm/kvm_main.c
@@ -2305,7 +2305,6 @@ int kvm_init(void *opaque, unsigned int
 		r = -ENOMEM;
 		goto out_free_0;
 	}
-	cpumask_clear(cpus_hardware_enabled);
 
 	r = kvm_arch_hardware_setup();
 	if (r < 0)

Re: [PATCH] kvm: remove the duplicated cpumask_clear

[Rusty Russell]

On Fri, 12 Jun 2009 07:39:00 am Yinghai Lu wrote:
> zalloc_cpumask_var already had that clear.

Only because of your previous patch... I've folded them into one patch for
Avi:

Subject: kvm: use zalloc_cpumask_var instead of cpumask_clear

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
---
 virt/kvm/kvm_main.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -2301,11 +2301,10 @@ int kvm_init(void *opaque, unsigned int 
 
 	bad_pfn = page_to_pfn(bad_page);
 
-	if (!alloc_cpumask_var(&cpus_hardware_enabled, GFP_KERNEL)) {
+	if (!zalloc_cpumask_var(&cpus_hardware_enabled, GFP_KERNEL)) {
 		r = -ENOMEM;
 		goto out_free_0;
 	}
-	cpumask_clear(cpus_hardware_enabled);
 
 	r = kvm_arch_hardware_setup();
 	if (r < 0)

Re: [PATCH] x86: use zalloc_cpumask_var in arch_early_irq_init

[Rusty Russell]

On Fri, 12 Jun 2009 07:37:48 am Yinghai Lu wrote:
> So could make sure MAXSMP get clearred cpumask
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>

Ingo, this only applies to your tree; can you take it?

Thanks,
Rusty.

Re: [PATCH] x86: use zalloc_cpumask_var in arch_early_irq_init

[Ingo Molnar]

* Rusty Russell <rusty@rustcorp.com.au> wrote:

> On Fri, 12 Jun 2009 07:37:48 am Yinghai Lu wrote:
> > So could make sure MAXSMP get clearred cpumask
> >
> > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> 
> Ingo, this only applies to your tree; can you take it?

should apply to upstream too so could go into your tree with the 
other cpumask changes, right?

	Ingo

Re: [PATCH] x86: use zalloc_cpumask_var in arch_early_irq_init

[Rusty Russell]

On Sat, 13 Jun 2009 12:30:42 am Ingo Molnar wrote:
> * Rusty Russell <rusty@rustcorp.com.au> wrote:
> > On Fri, 12 Jun 2009 07:37:48 am Yinghai Lu wrote:
> > > So could make sure MAXSMP get clearred cpumask
> > >
> > > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> >
> > Ingo, this only applies to your tree; can you take it?
>
> should apply to upstream too so could go into your tree with the
> other cpumask changes, right?

Yep, I hadn't pulled for a while.  I'll take it now.

Thanks,
Rusty.