From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] perfcounters: print a sorted summary of annotated overhead lines
Date: Sat, 13 Jun 2009 13:02:29 +0200 [thread overview]
Message-ID: <20090613110229.GB18924@elte.hu> (raw)
In-Reply-To: <1244844682-12928-2-git-send-email-fweisbec@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> It's can be very annoying to scroll down perf annotated output
> until we find relevant overhead.
>
> Using the -l option, you can now have a small summary sorted per
> overhead in the beginning of the output.
>
> Example:
>
> ./perf annotate -l -k ../../vmlinux -s __lock_acquire
>
> Sorted summary for file ../../vmlinux
> ----------------------------------------------
>
> 12.04 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:1653
> 4.61 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:1740
> 3.77 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:1775
> 3.56 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:1653
> 2.93 /home/fweisbec/linux/linux-2.6-tip/arch/x86/include/asm/irqflags.h:15
> 2.83 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:2545
> 2.30 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:2594
> 2.20 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:2388
> 2.20 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:730
> 2.09 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:730
> 2.09 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:138
> 1.88 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:2548
> 1.47 /home/fweisbec/linux/linux-2.6-tip/arch/x86/include/asm/irqflags.h:15
> 1.36 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:2594
> 1.36 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:730
> 1.26 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:1654
> 1.26 /home/fweisbec/linux/linux-2.6-tip/kernel/lockdep.c:1653
Nice!
I'm wondering how hard it would be to add wildcard support to the
symbol matching, say:
perf annotate "sys_*" # Annotate all syscalls
perf annotate "sched*" # All scheduler functions
perf annotate "*" # All symbols we know about
It would be slower, obviously - but pretty useful as well.
Also, perhaps an 'annotate top 10 overhead functions':
perf annotate --top 10
Would be popular too ...
Ingo
next prev parent reply other threads:[~2009-06-13 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 22:11 [PATCH 1/2] perfcounters: Print the filename:line for annotated colored lines Frederic Weisbecker
2009-06-12 22:11 ` [PATCH 2/2] perfcounters: print a sorted summary of annotated overhead lines Frederic Weisbecker
2009-06-13 11:02 ` Ingo Molnar [this message]
2009-06-13 14:48 ` [tip:perfcounters/core] perf annotate: Print " tip-bot for Frederic Weisbecker
2009-06-13 11:12 ` [PATCH 1/2] perfcounters: Print the filename:line for annotated colored lines Ingo Molnar
2009-06-13 12:35 ` Frederic Weisbecker
2009-06-13 14:48 ` [tip:perfcounters/core] perf annotate: " tip-bot for Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2009-06-13 15:25 [PATCH 1/2] perfcounters: " Frederic Weisbecker
2009-06-13 15:25 ` [PATCH 2/2] perfcounters: print a sorted summary of annotated overhead lines Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613110229.GB18924@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox